Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't support imagemagick-created avifs apparently #62

Closed
installgentoo opened this issue Apr 14, 2022 · 2 comments
Closed

Doesn't support imagemagick-created avifs apparently #62

installgentoo opened this issue Apr 14, 2022 · 2 comments

Comments

@installgentoo
Copy link

installgentoo commented Apr 14, 2022

Basically opening an image like https://github.com/installgentoo/assorted_curiosities/blob/master/trash/test.avif leads to error on

    // wrapping_sub is wanted. If num_planes is 0, this turns in a very big number that
    // still represents an invalid number of planes.
    let last_src_plane = src_format.num_planes.wrapping_sub(1);
    if !pixel_format::is_compatible(src_pixel_format, width, height, last_src_plane) {
        return Err(ErrorKind::InvalidValue);
    }
  • when this check is removed everything seems to work. I'm not sure whether this is a fault of how image-rs supplies data, or of this crate, or something else, so opening a bug here as well.

See image-rs/image#1647 for the investigation on this.

@fabiosky
Copy link
Contributor

See image-rs/image#1647 for discussion.
In summary, the caller api (image) is not respecting the current contract of the callee (dcv-color-primitives).

Proper solution is to have dcv color primitives handle color conversion removing the multiple of two restriction.
#65

@fabiosky
Copy link
Contributor

Closed in favor of #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants