-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(appsync): appsync Event API integration assertion tests #33572
fix(appsync): appsync Event API integration assertion tests #33572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
…wwendt/aws-cdk into appsync-eventapi-integ-assertion-tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33572 +/- ##
=======================================
Coverage 82.21% 82.21%
=======================================
Files 119 119
Lines 6876 6876
Branches 1162 1162
=======================================
Hits 5653 5653
Misses 1120 1120
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you for adding assertions!
Adding a |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
Improved assertion tests for newly added AppSync Event API + Channel namespace constructs. Improved documentation to show no channel namespace is created by default, one must be explicitly defined.
Description of changes
integ.appsync-event-api.ts
integ.appsync-eventapi-api-key-auth.ts
integ.appsync-eventapi-cognito-auth.ts
integ.appsync-eventapi-grants.ts
integ.appsync-eventapi-iam-auth.ts
integ.appsync-eventapi-lambda-auth.ts
To validate Cognito authorization, I needed to include the following package
@aws-sdk/client-cognito-identity-provider
which is whyyarn.lock
is updated in this PR.README.md
.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Integration tests all run successfully with passed assertion tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license