From 45a276fd0fc9b7b08f69f7faf3d0091796ab1663 Mon Sep 17 00:00:00 2001 From: go-to-k <24818752+go-to-k@users.noreply.github.com> Date: Sun, 2 Mar 2025 17:58:54 +0900 Subject: [PATCH] unit tests --- packages/aws-cdk-lib/aws-iam/lib/role.ts | 9 +-------- .../aws-cdk-lib/aws-iam/test/role.from-lookup.test.ts | 10 +++++++--- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/packages/aws-cdk-lib/aws-iam/lib/role.ts b/packages/aws-cdk-lib/aws-iam/lib/role.ts index 7a65d13aa4552..8794dcccf985c 100644 --- a/packages/aws-cdk-lib/aws-iam/lib/role.ts +++ b/packages/aws-cdk-lib/aws-iam/lib/role.ts @@ -272,14 +272,7 @@ export class Role extends Resource implements IRole { dummyValue: [ { // eslint-disable-next-line @cdklabs/no-literal-partition - // Arn: 'arn:aws:iam::123456789012:role/DUMMY_ARN', - Arn: Stack.of(scope).formatArn({ - region: '', - account: '123456789012', - service: 'iam', - resource: 'role', - resourceName: 'DUMMY_ARN', - }), + Arn: 'arn:aws:iam::123456789012:role/DUMMY_ARN', }, ], }).value; diff --git a/packages/aws-cdk-lib/aws-iam/test/role.from-lookup.test.ts b/packages/aws-cdk-lib/aws-iam/test/role.from-lookup.test.ts index 4fd0614726380..cc718c15b2c4e 100644 --- a/packages/aws-cdk-lib/aws-iam/test/role.from-lookup.test.ts +++ b/packages/aws-cdk-lib/aws-iam/test/role.from-lookup.test.ts @@ -1,5 +1,5 @@ import * as cxschema from '../../cloud-assembly-schema'; -import { ContextProvider, Stack, Token } from '../../core'; +import { CfnParameter, ContextProvider, Stack, Token } from '../../core'; import * as iam from '../lib'; /* eslint-disable */ @@ -46,10 +46,14 @@ describe('Role from lookup', () => { test('throw error if role name is a token', () => { // GIVEN - const tokenName = Token.asString('MyExistingRole'); const stack = new Stack(undefined, undefined, { env: { region: 'us-east-1', account: '123456789012' } }); + const param = new CfnParameter(stack, 'MyParam', { + type: 'String', + default: 'MyExistingRole', + }); + expect(() => iam.Role.fromLookup(stack, 'MyRole', { - roleName: tokenName, + roleName: param.valueAsString, })).toThrow(/All arguments to look up a role must be concrete \(no Tokens\)/); }); });