Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Cleanup of hexagonal structure #39

Open
hffmnn opened this issue Feb 3, 2022 · 0 comments
Open

[Question] Cleanup of hexagonal structure #39

hffmnn opened this issue Feb 3, 2022 · 0 comments

Comments

@hffmnn
Copy link
Contributor

hffmnn commented Feb 3, 2022

Hi and thanks a lot for this repository.

I am just getting started with the hexagonal architecture (and Rust in general) and I am wondering about some things in the current setup of the hexagonal architecture in this repo:

  • Why is model.rs not part of the domain?
  • Why does lib.rs have the comment Domain logic for the service but is not part of the domain?
  • Why aren't the port traits part of the Domain but part of the store? And what is a store in the naming conventions of a hexagonal architecture?

Don't get me wrong: I really like the repository, but I wonder if the boundaries could be a little bit more enforced.

When looking at another great example of a hexagonal architecture (in rust) and the source code of it, it looks like it is structured a little bit better, even if there are also issues around some implementation details: alexislozano/pokedex#1

Screenshot 2022-02-03 at 16 35 22

Would it be of interest for you to restructure the existing code? Maybe I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant