Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploying a new version results in Main being deployed #319

Open
dodge245 opened this issue Nov 6, 2024 · 2 comments
Open

Deploying a new version results in Main being deployed #319

dodge245 opened this issue Nov 6, 2024 · 2 comments

Comments

@dodge245
Copy link

dodge245 commented Nov 6, 2024

Describe the bug

All of the deployment scripts refer to the "main" branch in git, therefore when attempting to update to a new version its possible to deploy unwanted changes, for example the latest release 1.2.0 is 8 commits behind the "main" branch:

image

To Reproduce
Steps to reproduce the behavior:

  1. Run the Deploy.sh or update.sh scripts

Expected behavior

The version should be a variable that can be used to retrieve the correct version to deploy.

Additional context

Providing a link to the update.sh script as an example:

https://github.com/aws-samples/iam-identity-center-team/blob/main/deployment/update.sh#L30

if [ -z "$SECRET_NAME" ]; then
  git remote remove origin
  git remote add origin codecommit::$REGION://team-idc-app
  git remote add team https://github.com/aws-samples/iam-identity-center-team.git
  git pull team main

this should be updated to something like:

export VERSION=1.2.0

if [ -z "$SECRET_NAME" ]; then
  git remote remove origin
  git remote add origin codecommit::$REGION://team-idc-app
  git remote add team https://github.com/aws-samples/iam-identity-center-team.git
  git checkout -B main
  git pull team $VERSION
@neilherbertuk
Copy link

neilherbertuk commented Nov 7, 2024

This has been opened a couple of times and completely ignored.

This is a real problem as theres no defined way to deploy a specific version, main can and does contain un-released and potentially un-documented features as it may contain untagged commits.

@dodge245
Copy link
Author

bumping to ensure this does not get closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants