Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To remove .ts files while latest-build.zip is created on amplify push #7061

Closed
ravishankar82 opened this issue Apr 12, 2021 · 6 comments
Closed
Labels
feature-request Request a new feature functions Issues tied to the functions category

Comments

@ravishankar82
Copy link

ravishankar82 commented Apr 12, 2021

Note: If your feature-request is regarding the AWS Amplify Console service, please log it in the
AWS Amplify Console repository

Describe the solution you'd like
Can you please add a provision to remove .ts files from the latest-build.zip before running "amplify push".

@ravishankar82 ravishankar82 added the feature-request Request a new feature label Apr 12, 2021
@jhockett jhockett added the functions Issues tied to the functions category label Apr 13, 2021
@jhockett
Copy link
Contributor

@ravishankar82 how are you compiling your TypeScript code? Can you share your tsconfig.json?

We recommend keeping the TypeScript files in a separate folder in our docs which will prevent them from being included in latest-build.zip.

We are tracking more extensive TypeScript support in the following issues:
#659
#6507

@jhockett jhockett added question General question pending-close-response-required and removed feature-request Request a new feature labels Apr 14, 2021
@ravishankar82
Copy link
Author

ravishankar82 commented Apr 15, 2021

Yes, we can do if we place our source in another dir and pointing to build dir to src.
but I was expecting something to happen by amplify push under the hood.

you can close it if not planning to give such provision.

@jhockett
Copy link
Contributor

@ravishankar82 can you elaborate on why you'd like to see this change?

@jhockett jhockett added enhancement and removed question General question labels Apr 15, 2021
@ravishankar82
Copy link
Author

Because its unconventional in development point of view. If Amplify team suggesting use another folder its ok but there should be some option while creating amplify project using CLI command. At the time of amplify init there should be an option to select TypeScript and if developer select that one then this should ask about ts-src and js-src dir.

As Amplify does most of configuration things(creating folder dir and others) automatically at the time of initialization, in the same line of configuration we can give an option.

@jhockett
Copy link
Contributor

Thanks for elaborating on your use-case @ravishankar82. I'm going to close this issue in favor of the following issues #659
#6507.

@github-actions
Copy link

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2021
@josefaidt josefaidt added feature-request Request a new feature and removed enhancement labels Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request a new feature functions Issues tied to the functions category
Projects
None yet
Development

No branches or pull requests

3 participants