Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current ECS service setting is not honored when propagate-tags is not set #707

Open
mariuspaliga opened this issue Jan 13, 2025 · 2 comments · May be fixed by #712
Open

The current ECS service setting is not honored when propagate-tags is not set #707

mariuspaliga opened this issue Jan 13, 2025 · 2 comments · May be fixed by #712

Comments

@mariuspaliga
Copy link

When creating an ECS service, we set propagateTags to SERVICE. However, this value is reset to NONE during deployment using this action. After some debugging, we found that the propagate-tags parameter must be explicitly set to prevent overwriting the value.

This behavior is not ideal because it requires setting the same value in two different places (in Terraform and when calling this action). It would be better if the action honored the current setting when propagate-tags is not specified, rather than hardcoding it to NONE.

What is your opinion?

Related PR: #629

@guikcd
Copy link
Contributor

guikcd commented Jan 15, 2025

Hello, I'll look into it.

@guikcd guikcd linked a pull request Jan 17, 2025 that will close this issue
@guikcd
Copy link
Contributor

guikcd commented Jan 17, 2025

I've started to work on it. Before setting a default value to propagateTags, the code now fetch the current value. It seems that if there isn't a value at the service creation, the default is NONE (which was my default). This should not break anything.
I now need to adapt the tests.

Sorry again for the uncovered use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants