You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When creating an ECS service, we set propagateTags to SERVICE. However, this value is reset to NONE during deployment using this action. After some debugging, we found that the propagate-tags parameter must be explicitly set to prevent overwriting the value.
This behavior is not ideal because it requires setting the same value in two different places (in Terraform and when calling this action). It would be better if the action honored the current setting when propagate-tags is not specified, rather than hardcoding it to NONE.
I've started to work on it. Before setting a default value to propagateTags, the code now fetch the current value. It seems that if there isn't a value at the service creation, the default is NONE (which was my default). This should not break anything.
I now need to adapt the tests.
When creating an ECS service, we set
propagateTags
toSERVICE
. However, this value is reset toNONE
during deployment using this action. After some debugging, we found that the propagate-tags parameter must be explicitly set to prevent overwriting the value.This behavior is not ideal because it requires setting the same value in two different places (in Terraform and when calling this action). It would be better if the action honored the current setting when
propagate-tags
is not specified, rather than hardcoding it toNONE
.What is your opinion?
Related PR: #629
The text was updated successfully, but these errors were encountered: