-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshot encoding broken #2932
Comments
Rather than the data, do you have a reproduction? |
Yes, but it's quite big and I don't want create a minimal repro https://github.com/fisker/shared-configs Clone, Run |
That's fine, I can reproduce it. Somehow there is insufficient data; this may be a bug in https://www.npmjs.com/package/cbor but I'll have to do more digging. |
Found https://github.com/hildjj/node-cbor/tree/main/packages/cbor#highwatermark in the docs. This seems fixable then. |
* Encode snapshot data asynchronously, fixes #2932 * Async I/O when saving snapshots
Fixed in 4.0.1! |
Confirmed fixed in v4.0.1. |
I was not able to update snapshot in AVA4, I don't know what's the problem, but I assume that decodeSnapshots should be able decode data return from encodeSnapshots?
I logged the failed data
Data can't decode
The text was updated successfully, but these errors were encountered: