From e194141d14313039188adc3aa756d2928b5ab773 Mon Sep 17 00:00:00 2001
From: mcasquer <mcasquer@redhat.com>
Date: Mon, 18 Nov 2024 08:24:22 +0100
Subject: [PATCH] block_disk_not_default_options: creates new test case

Creates a new test case that boots up a VM with a disk
configured with non-common options such as packed or
page-per-vq. Unplug the disk and hotplugs it again.

Signed-off-by: Mario Casquero <mcasquer@redhat.com>
---
 qemu/tests/block_disk_not_default_options.py  | 82 +++++++++++++++++++
 .../cfg/block_disk_not_default_options.cfg    | 22 +++++
 2 files changed, 104 insertions(+)
 create mode 100644 qemu/tests/block_disk_not_default_options.py
 create mode 100644 qemu/tests/cfg/block_disk_not_default_options.cfg

diff --git a/qemu/tests/block_disk_not_default_options.py b/qemu/tests/block_disk_not_default_options.py
new file mode 100644
index 0000000000..4b81c0d720
--- /dev/null
+++ b/qemu/tests/block_disk_not_default_options.py
@@ -0,0 +1,82 @@
+from virttest import error_context, qemu_qtree
+
+from provider import disk_utilities
+from provider.block_devices_plug import BlockDevicesPlug
+
+
+@error_context.context_aware
+def run(test, params, env):
+    """
+    Test the disk non-default options.
+
+    Steps:
+        1. Boot a VM with packed=true and page-per-vq=true
+        2. Verify the packed and page-per-vq values
+        3. Do some basic I/O operation in the VM
+        4. Unplug and hotplug the disk
+        5. Do again a basic I/O operation
+
+    :param test: QEMU test object.
+    :param params: Dictionary with the test parameters.
+    :param env: Dictionary with test environment.
+    """
+
+    def verify_non_default_options(option_key, expected_value):
+        """Verify the non-default values.
+        :param option_key: the QEMU option to be checked.
+        :param expected_value: the QEMU option expected value.
+        """
+        error_context.context(f"Verify {option_key} from monitor.", test.log.info)
+        qtree = qemu_qtree.QtreeContainer()
+        qtree_option_value = False
+        try:
+            qtree.parse_info_qtree(vm.monitor.info("qtree"))
+        except AttributeError:
+            test.cancel("Monitor doesn't support qtree skip this test")
+        error_msg = (
+            f"'{option_key}' value mismatch: expected %s but report from monitor is: %s"
+        )
+
+        for node in qtree.get_nodes():
+            if (
+                isinstance(node, qemu_qtree.QtreeDev)
+                and node.qtree.get(option_key) == expected_value
+            ):
+                qtree_option_value = node.qtree.get(option_key)
+                error_context.context(
+                    f"The qtree_option_value: {qtree_option_value}", test.log.debug
+                )
+
+        if qtree_option_value != expected_value:
+            error_msg = error_msg % (str(expected_value), qtree_option_value)
+            test.fail(error_msg)
+
+    vm = env.get_vm(params["main_vm"])
+    vm.verify_alive()
+    session = vm.wait_for_login(timeout=360)
+
+    qtree_check_images = params.get("qtree_check_images", "stg0").split()
+
+    tmp_dir = params.get("tmp_dir", "/var/tmp/test")
+    disk_utilities.execute_cmd_on_disk_by_id(
+        params, qtree_check_images[0], session, tmp_dir
+    )
+
+    for image in qtree_check_images:
+        qtree_check_image = eval(params.get(f"qtree_check_{image}", "{}"))
+        if qtree_check_image:
+            for option_key in qtree_check_image:
+                error_context.base_context(
+                    f"Options to verify: {option_key} {qtree_check_image[option_key]}",
+                    test.log.debug,
+                )
+                verify_non_default_options(option_key, qtree_check_image[option_key])
+        else:
+            test.log.warning("There are no options to be checked in the qtree")
+
+    plug = BlockDevicesPlug(vm)
+    plug.unplug_devs_serial()
+    plug.hotplug_devs_serial()
+    disk_utilities.execute_cmd_on_disk_by_id(
+        params, qtree_check_images[0], session, tmp_dir
+    )
diff --git a/qemu/tests/cfg/block_disk_not_default_options.cfg b/qemu/tests/cfg/block_disk_not_default_options.cfg
new file mode 100644
index 0000000000..2c9736365e
--- /dev/null
+++ b/qemu/tests/cfg/block_disk_not_default_options.cfg
@@ -0,0 +1,22 @@
+- block_disk_not_default_options:
+    type = block_disk_not_default_options
+    only x86_64
+    start_vm = yes
+    images += " stg0"
+    boot_drive_stg0 = yes
+    image_name_stg0 = images/stg0
+    image_size_stg0 = 8G
+    remove_image_stg0 = yes
+    force_create_image_stg0 = yes
+    dd_cmd = "dd if=/dev/urandom of=test.txt bs=1M count=10"
+    blk_extra_params_stg0 = "serial=stg0"
+    variants:
+        - with_packed_and_ppv:
+            tmp_dir = /var/tmp/test
+            qtree_check_images = "stg0"
+            qtree_check_stg0 = '{"packed" : "true", "page-per-vq" : "true"}'
+            virtio_blk:
+                blk_extra_params_stg0 += ",packed=true,page-per-vq=true"
+            virtio_scsi:
+                bus_extra_params_stg0 = "packed=true,page-per-vq=true"
+                drive_bus_stg0 = 1