Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify copies of GenesisDomainParams across different crates #3352

Open
teor2345 opened this issue Jan 17, 2025 · 0 comments
Open

Unify copies of GenesisDomainParams across different crates #3352

teor2345 opened this issue Jan 17, 2025 · 0 comments
Labels
execution Subspace execution refactor

Comments

@teor2345
Copy link
Member

Currently, we have multiple copies of the GenesisDomainParams, GenesisDomain, DomainConfigParams and DomainConfig structs across different crates. This also means we have multiple copies of the code that converts between them.

It would make changes easier if we used a single copy of each struct, and split out the common parts into a struct shared by both of them.
If that's not possible, we should document where all the copies are, and why they exist.

For an example where all these structs needed to change, see PR #3350.

@teor2345 teor2345 added execution Subspace execution refactor labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Subspace execution refactor
Projects
None yet
Development

No branches or pull requests

1 participant