You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Overall, better tests need to be added to this part of the code.
The text was updated successfully, but these errors were encountered:
JaGeo
changed the title
filter_outlier_* does not work for the test data
9filter_outlier_* does not work for the test data (phonon workflow)
Dec 31, 2024
JaGeo
changed the title
9filter_outlier_* does not work for the test data (phonon workflow)
filter_outlier_* does not work for the test data (phonon workflow)
Dec 31, 2024
Are you sure it really writes data into the test.extxyz file? It is only supposed to write the files "filtered_in_energy.extxyz", "filtered_out_energy.extxyz" and "outliers_energy.extxyz". The line of code you mention is just for the file name (which assumes train.extxyz and test.extxyz are always together in the same folder).
filter_outlier_*
does not work correctly on test data. I am wondering if we need this at all.It actually writes data into the
test.extxyz
here as it only has a replace function for "train":autoplex/src/autoplex/data/common/utils.py
Line 480 in 3e0b5c5
If we use this, a different output name for the test data would need to be introduced.
Related to errors in #306 .
Overall, better tests need to be added to this part of the code.
The text was updated successfully, but these errors were encountered: