Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter_outlier_* does not work for the test data (phonon workflow) #313

Closed
JaGeo opened this issue Dec 31, 2024 · 3 comments
Closed

filter_outlier_* does not work for the test data (phonon workflow) #313

JaGeo opened this issue Dec 31, 2024 · 3 comments
Labels
bug Something isn't working phonon affects the phonon workflow only

Comments

@JaGeo
Copy link
Collaborator

JaGeo commented Dec 31, 2024

filter_outlier_* does not work correctly on test data. I am wondering if we need this at all.

It actually writes data into the test.extxyz here as it only has a replace function for "train":

path = Path(in_file).with_name(Path(in_file).name.replace("train", suffix))

If we use this, a different output name for the test data would need to be introduced.

Related to errors in #306 .

Overall, better tests need to be added to this part of the code.

@JaGeo JaGeo changed the title filter_outlier_* does not work for the test data 9filter_outlier_* does not work for the test data (phonon workflow) Dec 31, 2024
@JaGeo JaGeo changed the title 9filter_outlier_* does not work for the test data (phonon workflow) filter_outlier_* does not work for the test data (phonon workflow) Dec 31, 2024
@JaGeo JaGeo added bug Something isn't working phonon affects the phonon workflow only labels Dec 31, 2024
@QuantumChemist
Copy link
Collaborator

Are you sure it really writes data into the test.extxyz file? It is only supposed to write the files "filtered_in_energy.extxyz", "filtered_out_energy.extxyz" and "outliers_energy.extxyz". The line of code you mention is just for the file name (which assumes train.extxyz and test.extxyz are always together in the same folder).

@JaGeo
Copy link
Collaborator Author

JaGeo commented Jan 8, 2025

I am sure and I fixed it in #314 and #306 . It did not change anything on the fitting procedure as it takes the files from a step before.

@QuantumChemist
Copy link
Collaborator

ah ok, thank you for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working phonon affects the phonon workflow only
Projects
None yet
Development

No branches or pull requests

2 participants