Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of user provided yaml files #305

Open
naik-aakash opened this issue Dec 19, 2024 · 1 comment · May be fixed by #307
Open

Better handling of user provided yaml files #305

naik-aakash opened this issue Dec 19, 2024 · 1 comment · May be fixed by #307
Assignees
@naik-aakash
Labels
enhancement New feature or request

Comments

@naik-aakash
Copy link
Collaborator

We can possibly better handle yaml file loading by means of __post_init method in Makers. This should then result in not having to copy the yaml file onto remote clusters.
@naik-aakash naik-aakash added the enhancement New feature or request label Dec 19, 2024
@naik-aakash naik-aakash linked a pull request Dec 23, 2024 that will close this issue
Draft
9 tasks
@naik-aakash naik-aakash self-assigned this Dec 23, 2024
@JaGeo JaGeo mentioned this issue Dec 23, 2024
Merged
20 tasks
@JaGeo
Copy link
Collaborator

JaGeo commented Dec 23, 2024

or should we do this? https://github.com/materialsproject/pymatgen/blob/da607e86f9ce8aec942067c6c1a4fda6e04915dd/src/pymatgen/io/vasp/sets.py#L86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naik-aakash naik-aakash

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Adapt Makers to use pydantic models instead of yamls naik-aakash/autoplex
2 participants
@JaGeo @naik-aakash