Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefiles inconsistency #167

Open
midnightveil opened this issue Jul 17, 2024 · 0 comments
Open

Makefiles inconsistency #167

midnightveil opened this issue Jul 17, 2024 · 0 comments

Comments

@midnightveil
Copy link
Contributor

Not perhaps a bug, but odd:

The use of $^ vs $< is inconsistent throughout the makefiles (even when targets have a singular dependency, and so the difference doesn't matter — but is confusing when you add a second dependency)

12 files use $(LD) $(LDFLAGS) $^ $(LIBS) -o $@
10 files use $(LD) $(LDFLAGS) $< $(LIBS) -o $@

Other inconsistencies are present (e.g. ${} vs $()). Probably some sort of style guide would be good here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant