Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Save as HTML does not export collapsed tables #232

Open
nickcmaynard opened this issue Apr 2, 2015 · 3 comments · May be fixed by #233
Open

Save as HTML does not export collapsed tables #232

nickcmaynard opened this issue Apr 2, 2015 · 3 comments · May be fixed by #233
Labels
bug

Comments

@nickcmaynard
Copy link

A markdown document with embedded tables, like so:

| header | header |
| --- | --- |
| data | data |

Should export with collapsed borders, to render like so:

screen shot 2015-04-02 at 10 33 18

However, borders are not collapsed when "Save as HTML..." is used:

screen shot 2015-04-02 at 10 33 30

I'd suggest an additional rule be added to the export:

.markdown-preview table {
    border-collapse: collapse;
}
@nickcmaynard
Copy link
Author

@ArnaudRinquin FYI... this might be something you're interested in...

@ArnaudRinquin
Copy link
Contributor

Interesting. Save as HML... takes its CSS from the atom-editor and the markdown-preview package. I'll have a look were the border-collapse instruction comes from.

@ArnaudRinquin
Copy link
Contributor

Ahhh. It comes from normalize.css, which it server compiled with Atom's base css.

I am bot sure what's the proper way to export it as well.

ArnaudRinquin added a commit to ArnaudRinquin/markdown-preview that referenced this issue Apr 2, 2015
@ArnaudRinquin
Save as HTML also exports base css
ecbf789 
Base css is anything coming from `bootstrap.less`

Fixes atom#232
@ArnaudRinquin ArnaudRinquin linked a pull request Apr 2, 2015 that will close this issue
Open
@winstliu winstliu added the bug label Apr 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Save as HTML also exports base css ArnaudRinquin/markdown-preview
3 participants
@ArnaudRinquin @nickcmaynard @winstliu