Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Clicking on link in Markdown Preview doesn’t open #107

Closed
backspaces opened this issue Jul 15, 2014 · 8 comments
Closed

Clicking on link in Markdown Preview doesn’t open #107

backspaces opened this issue Jul 15, 2014 · 8 comments
Labels

Comments

@backspaces
Copy link

I'm running the latest Atom and Markdown Preview package.

When I click on links in the preview panel, nothing happens. Shouldn't it open the link in a browser or in Atom? Safari sez my default browser is Chrome, which it should be.

This could be a dumb mistake on my part, but if not, lets do add it. For now I'm solving markdown preview with a chrome extension, which does work.

-- Owen

@kevinsawicki
Copy link
Contributor

It should work, can you provide a snippet that doesn't work for you?

@backspaces
Copy link
Author

Thanks for the quick reply! Simply knowing it should work helps, let me
fuss about this afternoon and get back to you.

-- Owen

On Tue, Jul 15, 2014 at 10:42 AM, Kevin Sawicki [email protected]
wrote:

It should work, can you provide a snippet that doesn't work for you?


Reply to this email directly or view it on GitHub
#107 (comment)
.

@kevinsawicki
Copy link
Contributor

Can you try opening the dev tools with cmd-alt-I and run require('shell').openExternal('http://google.com') in there and see if it opens an external browser correctly?

@backspaces
Copy link
Author

Yes, using the dev tools console, pasting the script immediate produces a new tab in my open chrome browser. And if chrome is not running, it opens chrome. So this definitely works correctly, both with an open browser and one that is not running.

@kevinsawicki
Copy link
Contributor

Hmm, at this point, a markdown snippet that fails for you would be great just to see if I can reproduce your issue.

@backspaces
Copy link
Author

I'm working on a README.md for a github repo. I can wrap up a repo, sans unnecessary stuff.

But in the mean time, I've found a likely problem: the problem occurs only for relative urls. I.e. relative to the readme. So if my repo has a docs/ dir, and the readme has a relative url:

model.coffee is the top level integration for all the agentsets and is subclassed by all user models.

.. the link does not launch chrome. Possibly relative urls are the problem?

@kevinsawicki
Copy link
Contributor

Yup, there is already an open issue for that, thanks for letting me know.

Dupe of #85

@backspaces
Copy link
Author

Good .. sorry I wasn't as complete in my description as I should have been.

Just in case it helps in the future, here is a zip file of the repo minus
.git npm/node etc stuff.

Thanks for the great package, btw.

On Tue, Jul 15, 2014 at 1:21 PM, Kevin Sawicki [email protected]
wrote:

Yup, there is already an open issue for that, thanks for letting me know.

Dupe of #85 #85


Reply to this email directly or view it on GitHub
#107 (comment)
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants