Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Why <div> and not <ol> #17

Open
codepo8 opened this issue Feb 9, 2015 · 4 comments
Open

Why <div> and not <ol> #17

codepo8 opened this issue Feb 9, 2015 · 4 comments

Comments

@codepo8
Copy link

codepo8 commented Feb 9, 2015

That would give us line numbering for free.

@kevinsawicki
Copy link
Contributor

<div> was used originally to match Atom's HTML structure since it was important to allow themes to work there without changes. And since Atom has a separate gutter component, <div> is used there for all lines.

@codepo8
Copy link
Author

codepo8 commented Feb 9, 2015

Ah OK, that makes sense. Well, no, but it is a good reason :)

On Mon, Feb 9, 2015 at 6:07 PM, Kevin Sawicki [email protected]
wrote:

was used originally to match Atom's HTML structure since it was important to allow themes to work there without changes. And since Atom has a separate gutter component,
is used there for all lines.


Reply to this email directly or view it on GitHub
#17 (comment).

@kevinsawicki
Copy link
Contributor

Yeah, I'd be totally up for making this an option and having some sort of line number option available in this library.

@codepo8
Copy link
Author

codepo8 commented Feb 9, 2015

well, you can do a CSS counter on the DIV element and generate the numbers
with CSS.
http://christianheilmann.com/2014/11/19/simple-things-styling-ordered-lists/

On Mon, Feb 9, 2015 at 6:59 PM, Kevin Sawicki [email protected]
wrote:

Yeah, I'd be totally up for making this an option and having some sort of
line number option available in this library.


Reply to this email directly or view it on GitHub
#17 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants