Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to Syntax themes? #1

Open
simurai opened this issue Sep 26, 2015 · 3 comments
Open

Adapt to Syntax themes? #1

simurai opened this issue Sep 26, 2015 · 3 comments
Labels

Comments

@simurai
Copy link
Contributor

simurai commented Sep 26, 2015

Should this UI theme also adapt to syntax themes by using the syntax variables as a base? Like the One themes and others do it.

Pro: It would look much better because the current dark grey rarely matches any syntax's theme background color.

Con: On the other hand, the purpose of this theme is to make it as easy as possible for beginners to get started. Without any fancy stuff. So not sure.

@varemenos
Copy link

What if this was a checkbox option in the theme's settings?

@simurai
Copy link
Contributor Author

simurai commented Oct 10, 2015

Ya, maybe. The initial idea of this template is to be as simple as possible. More for people starting out and trying to create their first theme. Having an option in the settings might make it more complex.

@varemenos
Copy link

Well true but it might also give them an example, a starting point on how to implement options for their themes. I'm not saying it should be implemented, I'm just giving a counter argument :)

chiruchan added a commit to chiruchan/ui-theme-template that referenced this issue Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants