Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more abstraction for overlays and float panes #50

Open
illright opened this issue Jan 23, 2021 · 2 comments
Open

Provide more abstraction for overlays and float panes #50

illright opened this issue Jan 23, 2021 · 2 comments

Comments

@illright
Copy link

They provide similar functionality, are similar in appearance, suffer from the same issues and even have similar codebases. I believe we could be more efficient at maintaining both datatip and signature help functionality if we combine it in a single package that provides two services.

Additionally, this one is now TypeScript'ified, while atom-ide-signature-help isn't.

@lierdakil
Copy link
Contributor

This might make sense, with one caveat: signature help tooltip is similar to a datatip, but it has some distinct behaviours. In particular, you generally don't have dozens of datatips, but you can have dozens of signature helps (for overloaded functions). Being able to show one at a time and cycle through is a must (which is by the way something atom-ide didn't do particularly well)

@aminya
Copy link
Member

aminya commented Jan 24, 2021

As mentioned, they are different. The common code is already refactored and lives in atom-ide-base. Both use ViewContainer and ProviderRegister. But the remaining code is different.

We can make another abstraction on top of this, but I don't think it would be helpful.

@aminya aminya changed the title Merge the atom-ide-signature-help into this package Provide more abstraction for overlays and float panes Feb 2, 2021
@aminya aminya transferred this issue from atom-community/atom-ide-datatip Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants