Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] subscribe form retains incorrect data after subscription failure it should clear data after an error. #3622

Closed
2 tasks done
zalabhavy opened this issue Jan 29, 2025 · 2 comments
Closed
2 tasks done

[BUG] subscribe form retains incorrect data after subscription failure it should clear data after an error. #3622

zalabhavy opened this issue Jan 29, 2025 · 2 comments
Labels
bug

Comments

@zalabhavy
Copy link
Contributor

Describe the bug.

Screen.Recording.2025-01-29.at.10.02.28.PM.mov

When the newsletter subscription fails, the form still displays the incorrect data after 10 seconds when it reloads. The form should clear the input fields (email and name) after an error to prevent showing invalid data upon reload.

Expected behavior

clear incorrect data after subscription failure.

Screenshots

After Correction

Screen.Recording.2025-01-29.at.10.07.25.PM.mov

How to Reproduce

I will add condition if data is false and give some error so clear inputs of form.

🥦 Browser

Google Chrome

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

Yes I am willing to submit a PR!
@zalabhavy zalabhavy added the bug label Jan 29, 2025
@zalabhavy zalabhavy mentioned this issue Jan 29, 2025
Closed
@anshgoyalevil
Copy link
Member

That former behavior is correct. Suppose you typed in the wrong email unintentionally. Now, you would want the previous one to be displayed in the input fields so you can correct those and re-submit the form.

@anshgoyalevil
Copy link
Member

Closing it.

@anshgoyalevil anshgoyalevil closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: form clear after bug zalabhavy/websiteAsync
2 participants
@anshgoyalevil @zalabhavy