Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the edit-this-page-on-github workflow #3221

Closed
sambhavgupta0705 opened this issue Sep 13, 2024 · 19 comments · Fixed by #3557
Closed

Refactor the edit-this-page-on-github workflow #3221

sambhavgupta0705 opened this issue Sep 13, 2024 · 19 comments · Fixed by #3557
Assignees
Labels
bounty AsyncAPI Bounty program related label bug

Comments

@sambhavgupta0705
Copy link
Member

sambhavgupta0705 commented Sep 13, 2024

Describe the bug.

Ref: #3067

Issue Scope:
There are some doc pages that have their Edit this page on GitHub link pointing to some other MD file. We need to fix that thing.

@DhairyaMajmudar
Copy link
Contributor

@sambhavgupta0705 the PR resolving this one is here #3071

@sambhavgupta0705
Copy link
Member Author

sambhavgupta0705 commented Sep 13, 2024

@DhairyaMajmudar we need to reform the whole workflow as there are many errors in it so we need to check all the workflows which add docs in website

  1. markdown files are not redirecting properly
  2. create a template for adding docs in website
  3. create a logic to add new redirects

@sambhavgupta0705 sambhavgupta0705 changed the title Refactor the edit-this-page workflow Refactor the edit-this-page-on-github workflow Sep 13, 2024
@sambhavgupta0705
Copy link
Member Author

@DhairyaMajmudar would you like to work on this issue?

@DhairyaMajmudar
Copy link
Contributor

@DhairyaMajmudar would you like to work on this issue?

Yeah sure, let's do it

@sambhavgupta0705
Copy link
Member Author

okay
You may start working on it

@yuvrajkarna2717
Copy link

Hello, I noticed this issue and would like to contribute. Is it still open for work?

@BiradarScripts
Copy link

@sambhavgupta0705 can you review my pr

@aeworxet
Copy link
Contributor

aeworxet commented Dec 16, 2024

Bounty Issue's service comment

Text labels: bounty/2025-Q1, bounty/advanced, bounty/coding, bounty/upgraded
First assignment to regular contributors: 2024-12-20 00:00:00 UTC+12:00
End Of Life after: 2025-01-31 23:59:59 UTC-12:00

@asyncapi/bounty_team

The Bounty Program is not a Mentorship Program. The accepted level of Bounty Program Participants is Middle/Senior.
Regular contributors should explain in meaningful words how they are going to approach the resolution process when expressing a desire to work on this Bounty Issue.

@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty program related label label Dec 16, 2024
@aeworxet aeworxet moved this to No Assignee in Bounty Program Dec 16, 2024
@anshgoyalevil
Copy link
Member

@aeworxet I would be taking up this issue.

@aeworxet
Copy link
Contributor

@anshgoyalevil (githubID: 94157520) is an AsyncAPI Maintainer specified in https://raw.githubusercontent.com/asyncapi/community/master/MAINTAINERS.yaml, so they fall under the first category in the prioritization list.

@anshgoyalevil anshgoyalevil self-assigned this Dec 16, 2024
@aeworxet aeworxet moved this from No Assignee to In Progress in Bounty Program Dec 16, 2024
@aeworxet
Copy link
Contributor

Bounty Issue's Timeline

Complexity Level Assignment Date (by GitHub) Start Date (by BP Rules) End Date (by BP Rules) Draft PR Submission Final PR Merge Start Final PR Merge End
Medium 2024-12-16 2025-01-06 2025-02-16 2025-01-19 2025-02-02 2025-02-16
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

@anshgoyalevil
Copy link
Member

Hi @aeworxet
Upon discussion with @akshatnema about scope of this issue, that includes adding a cron job along with slack integration for workflow failures, this bounty issue needs to be reclassified to Advanced

@aeworxet
Copy link
Contributor

Upon request of the AsyncAPI Maintainer, who is also the Bounty Program Participant (@anshgoyalevil, githubID: 94157520), the Complexity Level of this Bounty Issue was reclassified to Advanced (upgraded) and its Timeline changed.

Bounty Issue was Reclassified and its Timeline changed

Complexity Level Assignment Date (by GitHub) Start Date (by BP Rules) End Date (by BP Rules) Draft PR Submission Final PR Merge Start Final PR Merge End
Advanced 2024-12-16 2025-01-06 2025-03-02 2025-01-26 2025-02-16 2025-03-02
Please note that the dates given represent deadlines, not specific dates, so if the goal is reached sooner, it's better.
Keep in mind the responsibility for violations of the Timeline.

Assignee: @anshgoyalevil (githubID: 94157520)

@ChaitanyaKadu03
Copy link

Hello @sambhavgupta0705 @anshgoyalevil @akshatnema @derberg ,

I've just opened a pull request to address the refactoring of the “Edit this page on GitHub” workflow. You can find it here: PR #3546.

Request for Review
If you spot anything that needs tweaking or if there’s additional feedback, I’m happy to make further changes.
I’ve tested the links locally, and they seem to be working correctly. Let me know if there’s any specific environment or scenario you want me to test further.

Thank You!
I appreciate your time reviewing this PR. Please let me know if there's anything else I can help with. I'm ready to implement any changes needed to get this merged smoothly!

@ChaitanyaKadu03
Copy link

If you’d like, I can add Jest tests to ensure that link logic remains stable going forward.

@sambhavgupta0705
Copy link
Member Author

@ChaitanyaKadu03 this issue is under bounty Program and @anshgoyalevil is working on it so we cannot proceed with your PR

@aeworxet
Copy link
Contributor

aeworxet commented Jan 6, 2025

@ChaitanyaKadu03

The GitHub issue participates in the AsyncAPI Bounty Program and is the responsibility of the assigned user.

You are welcome to choose another GitHub issue for contribution that does not have the bounty label.

@akshatnema
Copy link
Member

@aeworxet This Bounty issue is completed now.

@aeworxet
Copy link
Contributor

Bounty Issue Is Completed 🎉

@anshgoyalevil (githubID 94157520), please go to the AsyncAPI page on Open Collective and submit an invoice for USD 400.00 with the expense title Bounty website#3221, tag bounty, and full URL of this Bounty Issue in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment