-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Update on script npm run generator:test:cli
#1369
Comments
@derberg sir can you please provide feedback thanks : ) |
hey, the fact that we deprecated cli do not mean it is removed - cli test should be invoked - it is simple cli run - but should run afaik. Did you try to investigate why it doesn't run? maybe we have an error in turborepo config? |
@derberg sir on investigate I found a PR https://github.com/asyncapi/generator/pull/1315/files in which the test:cli was removed |
ah, ok, as it was using the deprecated CLI |
@derberg Sir, could you please provide more details about the approach so that I can add value in resolving the issue? |
very good point. Just that the cli test was not there really to test the cli itself, but rather test generator in most extreme integration test possible. Now yes, problem is that on a CI level, when we run cli test, it is not really testing the current generator, but the last one available in AsyncAPI CLI and because of above, I agree with you, please complete the removal of CLI test command - it really should be removed |
While running
npm run generator:test:cli
the script does not throw any errors but results in the following output:The last package update introduced the deprecation of ag. If no task are executed by the script should we proceed with removing this script from package.json and the documentation, or are there any team discussions/plans regarding this?
Please provide feedback and explanation.
The text was updated successfully, but these errors were encountered: