fix: remove the use of icon library as per discuss #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TenzDelek
requested review from
AceTheCreator,
thulieblack,
Mayaleeeee and
ashmit-coder
as code owners
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
ashmit-coder
requested changes
Jan 23, 2025
There was a problem hiding this comment.
@TenzDelek remove the package-lock.json changes from your pr.
fixed |
AceTheCreator
requested changes
Jan 28, 2025
There was a problem hiding this comment.
@ashmit-coder, but if we are removing a package, then changes has to occur in the package.lock file 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
as mentioned by @AceTheCreator #471 (comment) , we are currently only using lucide react for just one icon which seems very inconsistent.
Related issue(s)
fixes #471