-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed fails for New PRs Due to 2025 Year Change #507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
I will have a look at this pr later this week @Lemeri123 , the changes are good but they dont address the issue. Do ping me at the end of the week if it goes unmerged. |
Alright @ashmit-coder sure thing |
cc. @ashmit-coder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The Cypress test suite for the landing page has been updated to address the issue with dynamic year handling and to improve the maintainability and robustness of the tests. These changes ensure the tests accommodate year transitions and reduce the risk of failure due to hardcoded values.
closes #505