Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix all invalid DOM property warnings across the project #439

Closed
2 tasks done
toffee-k21 opened this issue Oct 24, 2024 · 3 comments
Closed
2 tasks done

[BUG] Fix all invalid DOM property warnings across the project #439

toffee-k21 opened this issue Oct 24, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@toffee-k21
Copy link
Contributor

Describe the bug.

Several DOM property warnings are being raised in the console due to the use of non-standard or incorrect property names. React requires camelCase property names, but multiple places in the project still use kebab-case, such as fill-rule, stroke-width, etc.

These warnings appear when running the project with React, and while they do not break functionality, they clutter the console and could lead to potential issues in future React versions.

Expected behavior

No warnings should appear in the console for invalid DOM properties, and all attributes should follow React’s camelCase convention.

Screenshots

Screenshot 2024-10-24 180758
Screenshot 2024-10-24 180805

How to Reproduce

  1. Run the project in a React environment (mention the version).
  2. Inspect the console for warnings like:
    "Warning: Invalid DOM property fill-rule. Did you mean fillRule?"
    "Warning: Invalid DOM property stroke-width. Did you mean strokeWidth?"

🥦 Browser

None

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

None

@toffee-k21 toffee-k21 added the bug Something isn't working label Oct 24, 2024
@arpitkuriyal
Copy link
Contributor

arpitkuriyal commented Oct 24, 2024

i can do this . Making PR soon

This was referenced Oct 24, 2024
@Sourya07
Copy link

Sir can i work on this issue @toffee-k21

@ashmit-coder
Copy link
Collaborator

Sir can i work on this issue @toffee-k21

@Sourya07 the issue has been resolved in the above pr's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants