-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove -f flag from asyncapi start command #1638
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks pretty good, although please take into account I'm not a maintainer here, so in depth review is needed from their side. I'm not involved here for some time, afaik you should not use console.log directly.
anyway, from code, without manual testing, I see you fulfilled requirements. I hope you did manual testing.
of course there is also a case of missing unit tests
/ptal |
@Amzani @Souvikns @AayushSaini101 @Shurtu-gal Please take a look at this PR. Thanks! 👋 |
Quality Gate passedIssues Measures |
After a brief look over the PR, I found the following:
|
as specified in linked issues, studio command works like this now:
|
Okay, makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rtm |
Description
Remove -f flag from asyncapi start command
asyncapi start command can now work without filename also
Fixes #1623
Case 1 Filename given in command by user.
Case 2 Filename not given in command by user but asyncapi.yaml default file is present in current working directory.
Case 3 Filename not given in command by user and asyncapi.yaml default file is not present in current working directory. Open studio with empty file.
Studio for Case 3