Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.6 part 4 - grid view #11

Merged
merged 4 commits into from
Feb 11, 2025
Merged

v1.6 part 4 - grid view #11

merged 4 commits into from
Feb 11, 2025

Conversation

jkcox
Copy link
Collaborator

@jkcox jkcox commented Feb 6, 2025

  • Users can toggle grid vs list view with front end UI
  • Editors can set initial view in block

@jkcox jkcox added the enhancement New feature or request label Feb 6, 2025
@jkcox jkcox linked an issue Feb 6, 2025 that may be closed by this pull request
app-webdir-ui 4.0 - new feature - grid #8
Open
@SteveRyan-ASU
Copy link
Member

Functionality added correctly. Default display settings implemented correctly when the block was first rendered on the screen. Grid view was possibly missing some styles when tested against the latest version of the Pitchfork theme, but as long as we can verify the results are as-intended when everything is updated fully, we'll be in business.

@jkcox
Copy link
Collaborator Author

jkcox commented Feb 11, 2025

Functionality added correctly. Default display settings implemented correctly when the block was first rendered on the screen. Grid view was possibly missing some styles when tested against the latest version of the Pitchfork theme, but as long as we can verify the results are as-intended when everything is updated fully, we'll be in business.

yes, there are some styles for grid in the last couple UDS releases. We are running v1.20.x

@SteveRyan-ASU
Copy link
Member

Verified. With an update to the parent theme, styles are as-expected. Great work @jkcox. 😄

@SteveRyan-ASU SteveRyan-ASU changed the base branch from jcox-v16p3 to develop February 11, 2025 17:22
@SteveRyan-ASU SteveRyan-ASU merged commit 0776d7a into develop Feb 11, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveRyan-ASU SteveRyan-ASU Awaiting requested review from SteveRyan-ASU

@wmcconnell wmcconnell Awaiting requested review from wmcconnell

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

app-webdir-ui 4.0 - new feature - grid
2 participants
@jkcox @SteveRyan-ASU