-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'SCRIPT_NUMBER_ID' column disappeared in Simbad.query_region() after v0.4.8 update #3209
Comments
@ManonMarchand I expect you'll have something to say on this? (@vsquicciarini you should expect to wait ~a week to hear back on this at least, as the relevant folks are on holiday right now) |
Indeed, there is now a single script even with multiple radii.
Edit: Might not be possible actually, cannot use an upload like in from astropy.coordinates import SkyCoord
from astropy.table import Table, hstack
import astropy.units as u
from astroquery.simbad import Simbad
# let's do a query for two centers
simbad = Simbad()
centers = Table({"ra": [0, 1], "dec": [0, 1], "cone_number": [0, 1]})
coo_centers = SkyCoord(centers["ra"], centers["dec"], unit="deg")
regions = simbad.query_region(coo_centers, radius="0.1d")
coo_result = SkyCoord(regions["ra"], regions["dec"], unit="deg")
# here, we do the cross match
idx1, idx2, _, _ = coo_centers.search_around_sky(coo_result, 0.1*u.deg)
hstack([regions[idx1], centers[["cone_number"]][idx2]])
|
Hello there,
it appears that the v0.4.8 of astroquery deleted the column 'SCRIPT_NUMBER_ID' when using the function Simbad.query_region(). The column, introduced here (#2047) was crucial to connect the unequivocally inputs and outputs of a query, by assigning each row a number corresponding to the i-th input region.
Apparently the column was renamed as 'object_number_id' in Simbad.query_objects() (#2954). However, no such column exists for Simbad.query_region().
Would it be possible to restore this column (even with a different name)?
Thank you in advance for your the consideration. :)
The text was updated successfully, but these errors were encountered: