Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Option to not add 'mastDownload' to download_path in Observations.download_products #3206

Open
etlam262 opened this issue Feb 8, 2025 · 3 comments
Labels

Comments

@etlam262
Copy link

etlam262 commented Feb 8, 2025

It's great that since #1150 it's possible to download data to a custom directory. However, 'mastDownload' is always appended to the download path even if it isn't the current directory.

It would be nice if there was an option to not do this to keep an existing directory structure cleaner. I was thinking about implementing this myself but it's hard to ensure a good default backwards compatible behavior since the default would change depending the value of the flat flag.

@snbianco
Copy link
Contributor

snbianco commented Feb 9, 2025

Thanks for opening this issue! Do you mean that if flat=False, there should be an option to not begin the downloaded filepath with mastDownload? So, for instance, if the download_dir were set to "test", the resulting path would be something like, test/<mission>/<obsid>/<filename> rather than test/mastDownload/<mission>/<obsid>/<filename>.

@etlam262
Copy link
Author

etlam262 commented Feb 9, 2025

Yes, that's exactly what I was thinking. For my use case however, I now solved it by downloading the files individually because I'm processing them further after the download.

@bsipocz bsipocz added the mast label Feb 10, 2025
@snbianco
Copy link
Contributor

Awesome! I'll add this to the backlog since it seems like you've found a workaround for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants