-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uv-lock chokes on dynamic version metadata in pre-commit.ci #35
Comments
I can guess what is going on actually: |
I ran into this as well, with the following pyproject.toml using the flit backend [build-system]
build-backend = 'flit_core.buildapi'
requires = ['flit_core >=3.4,<4']
[project]
dynamic = ['version'] The error
|
Just confirming that pre-commit.ci indeed disables network access: pre-commit-ci/issues#189 |
Looks like this issue might get resolved soon in astral-sh/uv#10622 |
Apparently this wasn't sufficient, see neutrinoceros/uv-pre-commit-reprod#3 |
Indeed, the issue is still there, here's an updated error
Here's our pyproject.toml in case that is helpful: https://github.com/aiidateam/aiida-core/blob/main/pyproject.toml |
I opened a tracking issue for the remaining work: astral-sh/uv#10689 |
Thank you. I see the issue you linked was resolved in uv 0.5.21. However, this still doesn't resolve this one, see neutrinoceros/uv-pre-commit-reprod#4 |
Interesting, it works for us: https://results.pre-commit.ci/run/github/77234579/1737200748.0L_2sy30S1eqbCv5JpbFkA Maybe there's something else in your pyproject.toml that's causing the build backend to be invoked? |
Hmm, your pyproject
We have
|
Here's a self-contained MRE repo: https://github.com/neutrinoceros/uv-pre-commit-reprod
It contains a bare Python package with minimal metadata, and uses
uv-lock
fromuv-pre-commit
.Seemingly, the important part is that
project::version
is declared as dynamic inpyproject.toml
:Meanwhile, locally, running
uv lock
directly or invokingpre-commit run --all-files
gives the expected result.I have no idea if this is an issue with
uv
,uv-pre-commit
, orpre-commit.ci
, so I thought I'd just report to the intermediate layer in that stack.Possibly related to #25
The text was updated successfully, but these errors were encountered: