Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document MSRV policy #16384

Merged
merged 1 commit into from
Feb 26, 2025
Merged

document MSRV policy #16384

merged 1 commit into from
Feb 26, 2025

Conversation

carljm
Copy link
Contributor

@carljm carljm commented Feb 25, 2025

This documents our minimum supported Rust version policy. See #16370

@carljm carljm added the documentation Improvements or additions to documentation label Feb 25, 2025
@carljm carljm requested a review from MichaReiser February 25, 2025 20:42
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is now stricter than what I had in mind as it disallows us to use a newer MSRV than stable - 2 -- without exception. I wonder if we should relax the phrasing to leave us some wiggle room.

@carljm
Copy link
Contributor Author

carljm commented Feb 26, 2025

That was my understanding of the commitment we were making to downstream. If redistributors can't count on having those two releases' time to catch up, then I'm not sure what the value is of documenting N-2 as a policy?

I'll go with whatever we agree on here, but to me that seems like a significant change that I'd want to be sure we're aligned on beyond just the two of us.

@MichaReiser
Copy link
Member

MichaReiser commented Feb 26, 2025

That was my understanding of the commitment we were making to downstream. If redistributors can't count on having those two releases' time to catch up, then I'm not sure what the value is of documenting N-2 as a policy?

I was mainly looking to document that MSRV bumps aren't considered breaking in terms of semver. Not breaking downstream packagers is in our own interest

@carljm
Copy link
Contributor Author

carljm commented Feb 26, 2025

My opinion is that the best way to not break downstream packagers is to set a clear policy and stick to it.

If we plan to do N-2, I think that should be documented somewhere, just for the benefit of future-us remembering what we decided, if nothing else.

If you'd like to propose a different version of this PR, maybe it would be simplest for you to put up an alternative PR?

@MichaReiser
Copy link
Member

As I said. I'm okay with the current version. It simply means that we no longer have the option to make an exception

@carljm
Copy link
Contributor Author

carljm commented Feb 26, 2025

Ok, will go ahead and land for now. If you feel it's important that we carve out an option for exceptions, we can discuss and consider that as a separate change.

@carljm carljm merged commit 5925327 into main Feb 26, 2025
20 checks passed
@carljm carljm deleted the cjm/msrvdoc branch February 26, 2025 15:09
dcreager added a commit that referenced this pull request Feb 27, 2025
* main:
  [red-knot] unify LoopState and saved_break_states (#16406)
  [`pylint`] Also reports `case np.nan`/`case math.nan` (`PLW0177`) (#16378)
  [FURB156] Do not consider docstring(s) (#16391)
  Use `is_none_or` in `stdlib-module-shadowing` (#16402)
  [red-knot] Upgrade salsa to include `AtomicPtr` perf improvement (#16398)
  [red-knot] Fix file watching for new non-project files (#16395)
  document MSRV policy (#16384)
  [red-knot] fix non-callable reporting for unions (#16387)
  bump MSRV to 1.83 (#16294)
  Avoid unnecessary info at non-trace server log level (#16389)
  Expand `ruff.configuration` to allow inline config (#16296)
  Start detecting version-related syntax errors in the parser (#16090)
dcreager added a commit that referenced this pull request Feb 27, 2025
* dcreager/dont-have-a-cow:
  [red-knot] unify LoopState and saved_break_states (#16406)
  [`pylint`] Also reports `case np.nan`/`case math.nan` (`PLW0177`) (#16378)
  [FURB156] Do not consider docstring(s) (#16391)
  Use `is_none_or` in `stdlib-module-shadowing` (#16402)
  [red-knot] Upgrade salsa to include `AtomicPtr` perf improvement (#16398)
  [red-knot] Fix file watching for new non-project files (#16395)
  document MSRV policy (#16384)
  [red-knot] fix non-callable reporting for unions (#16387)
  bump MSRV to 1.83 (#16294)
  Avoid unnecessary info at non-trace server log level (#16389)
  Expand `ruff.configuration` to allow inline config (#16296)
  Start detecting version-related syntax errors in the parser (#16090)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants