Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11+ distributions on Windows incorrectly refer to libcrypto-1_1.dll and libssl-1_1.dll from PYTHON.json #473

Open
ntamas opened this issue Jan 4, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@ntamas
Copy link
Contributor

ntamas commented Jan 4, 2025

The Windows builds of Python 3.11 and 3.12 (and maybe 3.13 as well - haven't checked) refer to libcrypto-1_1.dll and libssl-1_1.dll (32-bit) or their 64-bit variants from PYTHON.json, while the install/DLLs folder contains libcrypto-3.dll and libssl-3.dll. I don't know what the best way would be to fix this; one possibility is to replace -1_1 with -3 in all occurrences in CONVERT_TO_BUILTIN_EXTENSIONS of the Windows build script when the target Python version is 3.11 or above, but there might be a better way.

I'll be happy to submit a PR if you let me know how to proceed with this in a way that is acceptable for the maintainers.

@zanieb
Copy link
Member

zanieb commented Jan 4, 2025

Hm, I'm not super familiar with this part of the code yet but it looks like there are a couple things

  1. We should validate that the shared_depends actually exist, so this can't be wrong in the future?
  2. Instead of shared_depends_$arch we might want to introduce shared_depends_conditional with arch, depends, maximum-python-version, and minimum-python-version fields, similar to elsewhere, e.g.:

build_options_conditional:
- options:
- freethreaded+debug
- freethreaded+pgo+lto
minimum-python-version: "3.13"

includes-conditional:
- includes:
- Modules/_hacl
- Modules/_hacl/include
- Modules/_hacl/internal
minimum-python-version: "3.14"

Then we can split the definitions per Python version as necessary.

@zanieb zanieb added the bug Something isn't working label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants