-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editable menu color on mobile #207
Comments
the menu button on mobile uses a |
alishaevn
added a commit
that referenced
this issue
Feb 27, 2024
this move was done in preparation for allowing the toggle icon rendered by the "navbar-toggler" class to be styled with the same colors as the rest of the navbar. the colors exist in a "module.scss" file so that they can be imported into our ".scss" AND ".jsx" files. I also updated the colors from greyscale to match those in the webstore template. greyscale was chosen initially as not to spend too much time picking a color palette and distracting from component creation. using color now allows us to see some of the slight color variances better. - ref: #207
alishaevn
added a commit
that referenced
this issue
Feb 27, 2024
by default, the background image rendered by the "navbar-toggler-icon" class is a dark colored hamburger menu icon. since it uses an image, it was incapable of being dynamically styled with css alone. this commit replaces the "navbar-toggler-icon" class inside "navbar-toggler" with an editable svg, allowing us to change the color. - ref: #207
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
story
on the mobile view of the webstore, the menu button (3 lines) is always set to black. this should be editable so that apps with a dark colored header don't interfere with being able to see the menu button. (we're already able to change the color of the header links. we may be able to extend that color to the menu button as well).
acceptance criteria
demo
The text was updated successfully, but these errors were encountered: