Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make boxes clickable #200

Closed
2 tasks
summer-cook opened this issue Jan 29, 2024 · 1 comment · Fixed by #203
Closed
2 tasks

Make boxes clickable #200

summer-cook opened this issue Jan 29, 2024 · 1 comment · Fixed by #203
Assignees
@AragonJ13 @AdrianC113 @DaltonMcauliffe
Labels
good first issue Good for newcomers

Comments

@summer-cook
Copy link
Contributor

summer-cook commented Jan 29, 2024 •
edited
Loading

summary

currently it is not obvious that the featured service links on the homepage are links. the goal is to improve the user experience by making the entire card clickable instead of just the title

screenshots

Image

acceptance criteria

  • the entire card wrapping the featured service is a link that leads to creating a request for that service.
  • the title no longer has a link - only the card itself.

notes

Slack convo: https://assaydepot.slack.com/archives/C03FZDALABG/p1706288827939439?thread_ts=1706288784.268929&cid=C03FZDALABG
@crisr15 crisr15 added this to webstore Jan 26, 2024
@summer-cook summer-cook converted this from a draft issue Jan 29, 2024
@summer-cook summer-cook moved this to Ready for Development in webstore Jan 29, 2024
@alishaevn alishaevn removed this from webstore Jan 29, 2024
@summer-cook summer-cook added the good first issue Good for newcomers label Jan 29, 2024
@summer-cook
Copy link
Contributor Author

Next Link docs: https://nextjs.org/docs/pages/api-reference/components/link

AragonJ13 pushed a commit that referenced this issue Feb 1, 2024
Make boxes clickable
0ca3a26 
dquote>
dquote> -removed clickable link
dquote> -wrapped card in clickable link to new request
dquote> Co-authored-by: Dalton McAuliffe <[email protected]>
dquote> Co-authored-by: Adrian Carranza <[email protected]>
Ref:#200
@AragonJ13 AragonJ13 mentioned this issue Feb 1, 2024
Merged
@alishaevn alishaevn linked a pull request Feb 2, 2024 that will close this issue
200 Make Boxes Clickable #203
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AragonJ13 AragonJ13

@AdrianC113 AdrianC113

@DaltonMcauliffe DaltonMcauliffe

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

200 Make Boxes Clickable assaydepot/webstore-component-library
5 participants
@alishaevn @summer-cook @AragonJ13 @AdrianC113 @DaltonMcauliffe