-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SECURITY_ATTRIBUTES for windows is still not implemented #156
Comments
winapi defines this. Reusing the de-facto standard crate seems nice, unless anyone can think of any serious drawbacks. |
Adding the |
With Then there's the obvious problem of crate incompatibility: crate users will have their own bindings which are type-incompatible despite carrying the same name and layout. Is there any reason this type is needed, do we have to access the fields from within Ash? Otherwise we should probably keep all such pointers opaque types like |
I'm strongly in favor of an opaque pointer if it's sufficient. That seems to be the current case? |
`()` is an empty tuple which can be constructed, while `ffi::c_void` cannot. This is only ever used as an opaque pointer anyway and not used by Ash; those wishing to access members directly should cast it to a struct representation of choice (`winapi`, `windows-rs` or something custom). Fixes ash-rs#156
`()` is an empty tuple which can be constructed, while `ffi::c_void` cannot. This is only ever used as an opaque pointer anyway and not used by Ash; those wishing to access members directly should cast it to a struct representation of choice (`winapi`, `windows-rs` or something custom). Fixes #156
`()` is an empty tuple which can be constructed, while `ffi::c_void` cannot. This is only ever used as an opaque pointer anyway and not used by Ash; those wishing to access members directly should cast it to a struct representation of choice (`winapi`, `windows-rs` or something custom). Fixes #156
As noted in #950 this is not actually a pointer to easily cast, but a mutable borrow - and this doesn't allow Perhaps we should add it to the list of "opaque types" there to solve both issues? |
See https://github.com/MaikKlein/ash/blob/master/generator/src/lib.rs#L357-L360
Should we use a library for this? Or should we just implement it manually?
The text was updated successfully, but these errors were encountered: