Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Stale connection retries #37

Closed
St4NNi opened this issue Jun 12, 2023 · 1 comment
Closed

[bug] Stale connection retries #37

St4NNi opened this issue Jun 12, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@St4NNi
Copy link
Member

St4NNi commented Jun 12, 2023

Bug

If the internal notifier connection was not used for approx. 1 minute it goes stale and needs to be retried on the next occurrence, this results in an "Internal Notifier Error" error.

To fix this we should implement 2 measures:

  1. Add retry / backoff logic for random transport errors in tonic / h2
  2. Open a new backend connection for each user request
@St4NNi St4NNi added the bug Something isn't working label Jun 12, 2023
@St4NNi
Copy link
Member Author

St4NNi commented Jun 13, 2023

This will be mitigated by: arunaengine/aruna@6ffb29a

For a proper retry logic we should wait for: hyperium/tonic#733
and: tower-rs/tower#682

@St4NNi St4NNi closed this as completed Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant