Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e validation job for sidekiq-alive #107

Open
andrcuns opened this issue Dec 2, 2023 · 6 comments
Open

Add e2e validation job for sidekiq-alive #107

andrcuns opened this issue Dec 2, 2023 · 6 comments
Labels
ci CI related changes

Comments

@andrcuns
Copy link
Collaborator

andrcuns commented Dec 2, 2023

It would be very useful to have additional validation layer that checks sidekiq-alive is working in a real app scenario.

This could be done based on packaging example app in to a docker container and seeing if it returns the proper health check status.

@arturictus Would You mind givin me maintainer access in https://github.com/arturictus/sidekiq_alive_example repo? I would like to give this a try when I have a moment.

@andrcuns andrcuns added the ci CI related changes label Dec 2, 2023
@lucastosetto
Copy link
Collaborator

@andrcuns Do you still plan to work on this? If not, I'd be glad to help @arturictus .

@andrcuns
Copy link
Collaborator Author

@andrcuns Do you still plan to work on this? If not, I'd be glad to help @arturictus .

@lucastosetto Not at the moment, no.

@arturictus
Copy link
Owner

Hi @andrcuns,
I've been very disconnected from GitHub; I'm just catching up.
@andrcuns, I gave you access to the sidekiq_alive_example. It will not help you much since it's just a new Rails app, and I do not know which version of Rails.

@arturictus
Copy link
Owner

Hi @lucastosetto,
Nice to meet you.
I'm not working with Ruby any more, so I need help maintaining this library.
I can add you as a collaborator if you want to help.

@lucastosetto
Copy link
Collaborator

@arturictus Nice to meet you too. Sure, I'll be glad to help, thanks! Could you send the invitation again, please? That one expired.

@arturictus
Copy link
Owner

Hi @lucastosetto, sure, I send the invitation again.
Thanks for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI related changes
Projects
None yet
Development

No branches or pull requests

3 participants