Too many levels of symbolic links

[adrianlzt]

I have a directory with many markdown files used to take notes. In that directory structure there are symbolic links doing circular paths. For example:
/home/adrian/adrianRepo/web/apps/google/programacion -> ../../../programacion/google
/home/adrian/adrianRepo/programacion/google/apps -> /home/adrian/adrianRepo/web/apps/google

This seems to configure marksman returning this error:

[ERROR][2024-06-12 18:04:14] .../vim/lsp/rpc.lua:770    "rpc"   "/home/adrian/.local/share/nvim/mason/bin/marksman"     "stderr"        "[18:04:14 INF] <LSP Entry> Starting Marksman LSP server: {}\n"
[ERROR][2024-06-12 18:04:18] .../vim/lsp/rpc.lua:770    "rpc"   "/home/adrian/.local/share/nvim/mason/bin/marksman"     "stderr"        "---------------------------------------------------------------------------"
[ERROR][2024-06-12 18:04:18] .../vim/lsp/rpc.lua:770    "rpc"   "/home/adrian/.local/share/nvim/mason/bin/marksman"     "stderr"        "\n"
[ERROR][2024-06-12 18:04:18] .../vim/lsp/rpc.lua:770    "rpc"   "/home/adrian/.local/share/nvim/mason/bin/marksman"     "stderr"        "Marksman encountered a fatal error\nPlease, report the error at https://github.com/artempyanykh/marksman/issues\n---------------------------------------------------------------------------\n"
[ERROR][2024-06-12 18:04:18] .../vim/lsp/rpc.lua:770    "rpc"   "/home/adrian/.local/share/nvim/mason/bin/marksman"     "stderr"        "Marksman version: "
[ERROR][2024-06-12 18:04:18] .../vim/lsp/rpc.lua:770    "rpc"   "/home/adrian/.local/share/nvim/mason/bin/marksman"     "stderr"        "1.0.0.0\n"
[ERROR][2024-06-12 18:04:18] .../vim/lsp/rpc.lua:770    "rpc"   "/home/adrian/.local/share/nvim/mason/bin/marksman"     "stderr"        "OS: Arch Linux\n"
[ERROR][2024-06-12 18:04:18] .../vim/lsp/rpc.lua:770    "rpc"   "/home/adrian/.local/share/nvim/mason/bin/marksman"     "stderr"        "Arch: "
[ERROR][2024-06-12 18:04:18] .../vim/lsp/rpc.lua:770    "rpc"   "/home/adrian/.local/share/nvim/mason/bin/marksman"     "stderr"        "X64\n---------------------------------------------------------------------------\n"
[ERROR][2024-06-12 18:04:18] .../vim/lsp/rpc.lua:770    "rpc"   "/home/adrian/.local/share/nvim/mason/bin/marksman"     "stderr"        "Too many levels of symbolic links : '/home/adrian/adrianRepo/programacion/google/apps/programacion/apps/programacion/apps/programacion/apps/programacion/apps/programacion/apps/programacion/apps/programacion/apps/programacion/apps/programacion/ap
ps/programacion/apps/programacion/apps/programacion/apps/programacion/apps/programacion/apps/programacion/apps/programacion/apps/programacion/apps/programacion/apps/programacion/apps/gmail/script.md'\n"

I'm not sure how this could be fixed, but I think circular symbolic links could be normal.

Thanks!

[artempyanykh]

Thanks for reporting this @adrianlzt! I understand the problem. Not sure what's the best way to solve it though. Need to think for a bit.

(some vague concerns around uniqueness of paths to documents and also resolving symlinks to folders outside of the root folder; maybe reading workspace folder in a BFS fashion and picking the shortest paths could be enough...)

[adrianlzt]

Maybe just ignoring symlinks? Or an option to ignore them.

[tmuehlbacher]

Also hitting this on the fwupd repo. I didn't look at the impl too closely but the Rust walkdir crate has some logic to do cycle detection by tracking the parent dirs. Maybe that's useful 🙂 https://github.com/BurntSushi/walkdir/blob/2.5.0/src/lib.rs#L973

Thanks for this nice LSP! :)

[artempyanykh]

Thanks for this nice LSP! :)

Thanks for the kind words @tmuehlbacher!

Also hitting this on the fwupd repo

This https://github.com/fwupd/fwupd repo?

---

Yeah, this needs to be looked at. But it's been a pretty niche use-case so far, so didn't make it to the top of the list.

[tmuehlbacher]

Yes, that's the repo. For this particular case, I have a local workaround by extending the gitignore:

$ echo src/tests/sys >>.gitignore