Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating system tests mapping #557

Merged
merged 1 commit into from
Jan 5, 2025
Merged

updating system tests mapping #557

merged 1 commit into from
Jan 5, 2025

Conversation

kooomix
Copy link
Contributor

@kooomix kooomix commented Jan 5, 2025

PR Type

Enhancement


Description

  • Removed numerous unused or obsolete test mappings from system_test_mapping.json.

  • Updated ownership for various test mappings to reflect current responsibilities.

  • Adjusted target repositories and descriptions for several test mappings.

  • Streamlined and cleaned up the structure of the test mapping file.


Changes walkthrough 📝

Relevant files
Enhancement
system_test_mapping.json
Refactored and updated test mappings and ownership             

system_test_mapping.json

  • Removed unused or outdated test mappings.
  • Updated ownership fields for multiple test cases.
  • Adjusted target repositories and descriptions for clarity.
  • Simplified and cleaned up the JSON structure.
  • +111/-699

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 Security concerns

    Email exposure:
    The file contains multiple email addresses that could be harvested for spam or phishing attacks. Consider obfuscating or removing email addresses from the mapping file.

    ⚡ Recommended focus areas for review

    Missing Description

    Several test entries have empty description fields which could make it harder to understand test purposes and requirements

    "skip_on_environment": "",
    "owner": "[email protected]"
    Duplicate Entry

    The 'scan_with_exceptions' test appears to be defined twice in the mapping file

    "scan_with_exceptions": {
      "target": [
        "CLI"
      ],
      "target_repositories": [
        "cadashboardbe"
      ],
      "description": "",
      "skip_on_environment": "",
      "owner": "[email protected]"
    },
    "ac_alpine_fix_image_no_relevancy_with_cronjob": {

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Remove duplicate test case definition to prevent ambiguity and potential execution issues

    The test case "ac_alpine_fix_image_no_relevancy_with_cronjob" appears to be
    duplicated in the mapping file. Remove one of the duplicate entries to avoid
    confusion and potential test execution issues.

    system_test_mapping.json [13-25]

    +# Remove one of the duplicate entries, keeping only a single instance of:
     "ac_alpine_fix_image_no_relevancy_with_cronjob": {
       "target": [
         "CLI",
         "Backend"
       ],
       "target_repositories": [        
         "cadashboardbe-dummy",
         "event-ingester-service-dummy"
       ],
       "description": "This test checks the scenario of fixing an AC by fixing the image without relevancy info with cronjob.",
       "skip_on_environment": "",
       "owner": "[email protected]"
     },
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Having duplicate test case definitions can cause confusion and potential test execution issues. The suggestion correctly identifies a duplicated test case entry that should be removed to maintain a clean and unambiguous test mapping.

    8

    Copy link

    github-actions bot commented Jan 5, 2025

    Failed to generate code suggestions for PR

    @kooomix kooomix merged commit 985716e into master Jan 5, 2025
    3 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants