Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Overlays aren't being added properly #360

Open
1 task done
MeestorX opened this issue Jan 6, 2025 · 10 comments
Open
1 task done

[Bug]: Overlays aren't being added properly #360

MeestorX opened this issue Jan 6, 2025 · 10 comments
Labels
Bug Something isn't working as it should Good first issue Feel free to contribute :)

Comments

@MeestorX
Copy link

MeestorX commented Jan 6, 2025

What happened?

Using the latest armbian-config, if you select overlays to be added, it puts them into armbianEnv.txt, but it's not respecting the overlay_prefix= setting. It's adding the full name of the overlay, and then the boot loader is prefixing that name with the overlay_prefix.
Deleting the overlay_prefix= line in armbianEnv.txt does not fix the problem, because it still prefixes a "-" ahead of the name.

How to reproduce?

Examples and more information here: https://forum.armbian.com/topic/47793-overlays-do-not-apply-even-when-selected-in-armbian-config-and-then-rebooting/#findComment-210335

On which host OS are you running the build script and observing this problem?

Debian 12 Bookworm

Code of Conduct

  • I agree to follow this project's Code of Conduct
@MeestorX MeestorX added the Bug Something isn't working as it should label Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

Hey @MeestorX !

Looks like it's your first time interacting with Armbian here on GitHub.

Welcome and thank you for taking the time to report an issue ❤️.

Don't forget to star ⭐ the repo.

@github-actions github-actions bot added the Good first issue Feel free to contribute :) label Jan 6, 2025
@igorpecovnik
Copy link
Member

This bug should be gone. Please update armbian-config to latest version.

@MeestorX
Copy link
Author

MeestorX commented Jan 6, 2025

I ran apt update and apt upgrade, do I need to do something else to get the latest?

@igorpecovnik
Copy link
Member

No, that's it.

@MeestorX
Copy link
Author

MeestorX commented Jan 6, 2025

Ok, I had updated before I posted, and it's still not working properly, unless I'm doing something wrong? Details are in the link but let me know if you need additional information.

@igorpecovnik
Copy link
Member

Then this is a bug, probably beyond this config program and we will look into in when possible. I think there were some mentioning on how to fix on forums, various hardware. There are some troubles with overlays, but don't know if all were fixed. I think on the armbian-config side it was this #310

@MeestorX
Copy link
Author

MeestorX commented Jan 6, 2025

And maybe this: #299

@igorpecovnik
Copy link
Member

Oh yes, that. But that should fix it, hmm.

@MeestorX
Copy link
Author

MeestorX commented Jan 6, 2025

The fix currently (as I put in the forum post) is to edit the overlay names in armbianEnv.txt, removing the prefix.

@igorpecovnik
Copy link
Member

Yeah, this is build issue. Image is from here, right: https://www.armbian.com/radxa-rock-s0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as it should Good first issue Feel free to contribute :)
Projects
None yet
Development

No branches or pull requests

2 participants