From 7df0fe29a6a07b7406b180ead7c67d852bfb69e6 Mon Sep 17 00:00:00 2001
From: Mladjan Gadzic <gadzic.mladjan@gmail.com>
Date: Mon, 23 Dec 2024 12:00:25 +0100
Subject: [PATCH] fix-ci (#4)

* create maven profiles, use ci profile for release, include getting and creating proto files for local profile only
---
 .github/workflows/ci.yml |   4 +-
 pom.xml                  | 266 +++++++++++++++++++++------------------
 2 files changed, 148 insertions(+), 122 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index b632666..85965f3 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -28,7 +28,7 @@ jobs:
       run: |
         cp settings.xml /home/runner/.m2
         cat /home/runner/.m2/settings.xml
-        mvn clean install -DskipTests
+        mvn clean install
       env:
         MAVEN_GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
 
@@ -37,7 +37,7 @@ jobs:
         pwd
         ls -la /home/runner/.m2
         cat /home/runner/.m2/settings.xml
-        mvn --batch-mode deploy -DskipTests
+        mvn --batch-mode deploy -DskipTests -Pci
       env:
         MAVEN_USERNAME: ${{ secrets.OSSRH_USERNAME }}
         MAVEN_PASSWORD: ${{ secrets.OSSRH_PASSWORD }}
diff --git a/pom.xml b/pom.xml
index d635097..c0db1a0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -46,7 +46,8 @@
 
   <scm>
     <connection>scm:git:git://github.com/armadaproject/java-client.git</connection>
-      <developerConnection>scm:git:ssh://github.com:armadaproject/java-client.git</developerConnection>
+    <developerConnection>scm:git:ssh://github.com:armadaproject/java-client.git
+    </developerConnection>
     <url>http://github.com/armadaproject/java-client/tree/main</url>
     <tag/>
   </scm>
@@ -58,6 +59,150 @@
     </repository>
   </distributionManagement>
 
+  <profiles>
+    <profile>
+      <id>local</id>
+      <properties>
+        <env>local</env>
+      </properties>
+      <activation>
+        <activeByDefault>true</activeByDefault>
+      </activation>
+      <build>
+        <plugins>
+          <!-- get proto files -->
+          <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>exec-maven-plugin</artifactId>
+            <version>${exec-maven-plugin.version}</version>
+            <executions>
+              <execution>
+                <id>clone-armada-repo</id>
+                <phase>generate-sources</phase>
+                <goals>
+                  <goal>exec</goal>
+                </goals>
+                <configuration>
+                  <executable>git</executable>
+                  <arguments>
+                    <argument>clone</argument>
+                    <argument>https://github.com/armadaproject/armada.git</argument>
+                    <argument>${project.build.directory}/armada</argument>
+                  </arguments>
+                </configuration>
+              </execution>
+              <execution>
+                <id>clone-api-repo</id>
+                <phase>generate-sources</phase>
+                <goals>
+                  <goal>exec</goal>
+                </goals>
+                <configuration>
+                  <executable>git</executable>
+                  <arguments>
+                    <argument>clone</argument>
+                    <argument>https://github.com/kubernetes/api.git</argument>
+                    <argument>${project.build.directory}/k8s.io/api</argument>
+                  </arguments>
+                </configuration>
+              </execution>
+              <execution>
+                <id>clone-apimachinery-repo</id>
+                <phase>generate-sources</phase>
+                <goals>
+                  <goal>exec</goal>
+                </goals>
+                <configuration>
+                  <executable>git</executable>
+                  <arguments>
+                    <argument>clone</argument>
+                    <argument>https://github.com/kubernetes/apimachinery.git</argument>
+                    <argument>${project.build.directory}/k8s.io/apimachinery</argument>
+                  </arguments>
+                </configuration>
+              </execution>
+            </executions>
+          </plugin>
+
+          <!-- copy proto files -->
+          <plugin>
+            <artifactId>maven-resources-plugin</artifactId>
+            <version>${maven-resources-plugin.version}</version>
+            <executions>
+              <execution>
+                <id>copy-protos</id>
+                <phase>generate-sources</phase>
+                <goals>
+                  <goal>copy-resources</goal>
+                </goals>
+                <configuration>
+                  <outputDirectory>${project.basedir}/src/main/proto</outputDirectory>
+                  <resources>
+                    <resource>
+                      <directory>${project.build.directory}/armada</directory>
+                      <includes>
+                        <include>pkg/api/*.proto</include>
+                        <include>pkg/api/binoculars/*.proto</include>
+                      </includes>
+                    </resource>
+                    <resource>
+                      <directory>${project.build.directory}</directory>
+                      <includes>
+                        <include>k8s.io/api/core/v1/generated.proto</include>
+                        <include>k8s.io/api/networking/v1/generated.proto</include>
+                        <include>k8s.io/apimachinery/pkg/api/resource/generated.proto</include>
+                        <include>k8s.io/apimachinery/pkg/apis/meta/v1/generated.proto</include>
+                        <include>k8s.io/apimachinery/pkg/runtime/generated.proto</include>
+                        <include>k8s.io/apimachinery/pkg/runtime/schema/generated.proto</include>
+                        <include>k8s.io/apimachinery/pkg/util/intstr/generated.proto</include>
+                      </includes>
+                    </resource>
+                  </resources>
+                </configuration>
+              </execution>
+            </executions>
+          </plugin>
+        </plugins>
+      </build>
+    </profile>
+
+    <profile>
+      <id>ci</id>
+      <properties>
+        <env>ci</env>
+      </properties>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.sonatype.central</groupId>
+            <artifactId>central-publishing-maven-plugin</artifactId>
+            <version>0.6.0</version>
+            <extensions>true</extensions>
+            <configuration>
+              <publishingServerId>central</publishingServerId>
+              <autoPublish>true</autoPublish>
+            </configuration>
+          </plugin>
+
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-gpg-plugin</artifactId>
+            <version>3.2.7</version>
+            <executions>
+              <execution>
+                <id>sign-artifacts</id>
+                <phase>verify</phase>
+                <goals>
+                  <goal>sign</goal>
+                </goals>
+              </execution>
+            </executions>
+          </plugin>
+        </plugins>
+      </build>
+    </profile>
+  </profiles>
+
   <build>
     <plugins>
       <!-- detect os -->
@@ -74,99 +219,6 @@
         </executions>
       </plugin>
 
-      <!-- get proto files -->
-      <plugin>
-        <groupId>org.codehaus.mojo</groupId>
-        <artifactId>exec-maven-plugin</artifactId>
-        <version>${exec-maven-plugin.version}</version>
-        <executions>
-          <execution>
-            <id>clone-armada-repo</id>
-            <phase>generate-sources</phase>
-            <goals>
-              <goal>exec</goal>
-            </goals>
-            <configuration>
-              <executable>git</executable>
-              <arguments>
-                <argument>clone</argument>
-                <argument>https://github.com/armadaproject/armada.git</argument>
-                <argument>${project.build.directory}/armada</argument>
-              </arguments>
-            </configuration>
-          </execution>
-          <execution>
-            <id>clone-api-repo</id>
-            <phase>generate-sources</phase>
-            <goals>
-              <goal>exec</goal>
-            </goals>
-            <configuration>
-              <executable>git</executable>
-              <arguments>
-                <argument>clone</argument>
-                <argument>https://github.com/kubernetes/api.git</argument>
-                <argument>${project.build.directory}/k8s.io/api</argument>
-              </arguments>
-            </configuration>
-          </execution>
-          <execution>
-            <id>clone-apimachinery-repo</id>
-            <phase>generate-sources</phase>
-            <goals>
-              <goal>exec</goal>
-            </goals>
-            <configuration>
-              <executable>git</executable>
-              <arguments>
-                <argument>clone</argument>
-                <argument>https://github.com/kubernetes/apimachinery.git</argument>
-                <argument>${project.build.directory}/k8s.io/apimachinery</argument>
-              </arguments>
-            </configuration>
-          </execution>
-        </executions>
-      </plugin>
-
-      <!-- copy proto files -->
-      <plugin>
-        <artifactId>maven-resources-plugin</artifactId>
-        <version>${maven-resources-plugin.version}</version>
-        <executions>
-          <execution>
-            <id>copy-protos</id>
-            <phase>generate-sources</phase>
-            <goals>
-              <goal>copy-resources</goal>
-            </goals>
-            <configuration>
-              <outputDirectory>${project.basedir}/src/main/proto</outputDirectory>
-              <resources>
-                <resource>
-                  <directory>${project.build.directory}/armada</directory>
-                  <includes>
-                    <include>pkg/api/*.proto</include>
-                    <include>pkg/api/binoculars/*.proto</include>
-                  </includes>
-                </resource>
-                <resource>
-                  <directory>${project.build.directory}</directory>
-                  <includes>
-                    <include>k8s.io/api/core/v1/generated.proto</include>
-                    <include>k8s.io/api/networking/v1/generated.proto</include>
-                    <include>k8s.io/apimachinery/pkg/api/resource/generated.proto</include>
-                    <include>k8s.io/apimachinery/pkg/apis/meta/v1/generated.proto</include>
-                    <include>k8s.io/apimachinery/pkg/runtime/generated.proto</include>
-                    <include>k8s.io/apimachinery/pkg/runtime/schema/generated.proto</include>
-                    <include>k8s.io/apimachinery/pkg/util/intstr/generated.proto</include>
-                  </includes>
-                </resource>
-              </resources>
-            </configuration>
-          </execution>
-        </executions>
-      </plugin>
-
       <!-- compile java -->
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
@@ -231,32 +283,6 @@
           </execution>
         </executions>
       </plugin>
-
-      <plugin>
-        <groupId>org.sonatype.central</groupId>
-        <artifactId>central-publishing-maven-plugin</artifactId>
-        <version>0.6.0</version>
-        <extensions>true</extensions>
-        <configuration>
-          <publishingServerId>central</publishingServerId>
-          <autoPublish>true</autoPublish>
-        </configuration>
-      </plugin>
-
-      <plugin>
-        <groupId>org.apache.maven.plugins</groupId>
-        <artifactId>maven-gpg-plugin</artifactId>
-        <version>3.2.7</version>
-        <executions>
-          <execution>
-            <id>sign-artifacts</id>
-            <phase>verify</phase>
-            <goals>
-              <goal>sign</goal>
-            </goals>
-          </execution>
-        </executions>
-      </plugin>
     </plugins>
   </build>