Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes should be labelled as such #3077

Open
purajit opened this issue Dec 12, 2024 · 2 comments
Open

Breaking changes should be labelled as such #3077

purajit opened this issue Dec 12, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@purajit
Copy link

purajit commented Dec 12, 2024

Is your feature request related to a problem?

For the last several months, we've been trying to debug an issue that we had a hard time isolating to any version of ArgoCD, and I finally discovered that it was because of a breaking change in the Helm chart (#2407). It was released here with no notes; in fact, the "chore" label only serves to make it harder to understand the significance.

Looking at the release history, the word "breaking" never shows up across the 1000+ releases, though there definitely have been:
image

We have one other issue we've been dealing with, and I'm going through our config and comparing it with the chart to see if we potentially might have another breaking change we didn't catch.

Related helm chart

argo-cd

Describe the solution you'd like

Breaking changes should be labelled as such; this is a common part of release process, and since ArgoCD is a release process project, it should follow this standard processes.

Describe alternatives you've considered

Trying to track and read each commit while upgrading charts is often not doable; people can search for certain terms like "deprecate", but this isn't really scalable, and since the Argo team understands their own changes the best to know if it's breaking or not, it would be good for it to be done officially.

Additional context

No response

@purajit purajit added the enhancement New feature or request label Dec 12, 2024
@yu-croco
Copy link
Collaborator

FYI

@purajit
Copy link
Author

purajit commented Dec 13, 2024

Ah gotcha, thanks for the response!

Looks like this change was missed in the 6.0.0 notes (there are other notes about ingress, but not this). Labeling commits while they're being done seems like it would be easier and more scalable (than manually reading commits and summarizing, which could be done in addition if needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants