You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When using the memory editor for N64 trying to overwrite a byte types 2 characters instead of 1 for the key input. For example, If I want to set a byte to "C0" when I type C on the keyboard I get "CC".
To Reproduce
Steps to reproduce the behavior:
Load an N64 Rom
Open Memory Editor from Tools
Find a bye in RDRAM
Try to edit byte
Expected behavior
Typing a character should only overwrite 1 character, not two.
Screenshots
Before typing C I have cursor in front of "22".
After typing C once, 22 became CC, when it should have become C2.
The text was updated successfully, but these errors were encountered:
I could have sworn there was already an open issue for this but I'm having trouble locating it now. However this is a known issue. If it helps, the issue is Windows specific (works properly on Linux and MacOS).
More info:
Basically in hiro/windows/application.cpp it is reading in key presses, where in the Linux & MacOS implementations of application they do not. The memory editor window itself, on all platforms, is also trapping key press events. The presence of both on Windows results in it capturing input twice, and thus outputting this double input capture (you can comment out this part in windows/application.cpp and the memory editor works fine). I'm just not really sure why it was done differently for Windows. I looked at the commit at one point (long time ago, done by Near) where that change happened, but I don't think it was obvious as to why it needed to be special cased on this platform, or maybe I just didn't spend enough time trying to figure it out. Needs to be reviewed in more detail.
Describe the bug
When using the memory editor for N64 trying to overwrite a byte types 2 characters instead of 1 for the key input. For example, If I want to set a byte to "C0" when I type C on the keyboard I get "CC".
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Typing a character should only overwrite 1 character, not two.
Screenshots
Before typing C I have cursor in front of "22".
After typing C once, 22 became CC, when it should have become C2.
The text was updated successfully, but these errors were encountered: