-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotation Axis and Start Angle behaviour is inconsistent #4
Comments
@michel4j this is the documentation for the marccd_server application: Look at the section called Remote Commands, and the documentation for the "header" command. Note that it only supports start_phi, it does not include a start_omega or other angle. Since the driver needs to send the "start_phi" command it seems to be up to the user to set that to whatever angle is actually being moved? I am not sure how you would like to change the driver given the limitation of the header command? |
@MarkRivers I see. I think their documentation may be incomplete. Looking at the marccd_client_socket.c file included with the marccd_socket_server, it does the following: sprintf(buffer, "header,rotation_axis=%s,detector_distance=%.3f,source_wavelength=%.6f,beam_x=%.3f,beam_y=%.3f,exposure_time=%.3f,phi=%.3f,omega=%.3f", "Phi", 100.0, 1.234567, 1024.0, 1025.0, exposure_time, phi, 45.0); This implies that the following header commands are also supported:
A while ago, we used the "phi" header command instead of the "start_phi". Or rather, the command was the same as the rotation axis. The marccd software would itself correctly set the appropriate start_xxx and end_xxx header variables. |
I have written to Rayonix asking them to clarify the disagreement between the manual and the example C code. |
I don't think that I have ever actually tried to access that metadata from the TIFF files that marccd writes before. I am examining a file that was definitely written by marccd, controlled by ADmarCCD, so it was setting phi_start, etc. This is the output of tiffinfo:
This is the output of tiffdump:
This is the output of "strings" which just shows the printable text at the start of the file:
I don't see the metadata like phi_start with any of those 3 ways of examining the file? @michel4j how did you access that information? |
Ross Doyle from Rayonix told me that I need to use the dump_header program to see the metadata values. That works:
We would need to test to see if writing a value for omega would actually result in this header being correct. |
There's also http://www.biophysics.fsu.edu/~xray/Manuals/marCCD165header.html which I used to write a python module for parsing it. https://github.com/michel4j/mxio/blob/master/mxio/formats/marccd.py |
The wrong header is written to images if MAR_ROTATION_AXIS is set to anything other than "phi". Since there is no MAR_START_OMEGA. Writing the starting angle value to MAR_START_PHI always updates the Phi starting angle in the header irrespective of which axis is set.
Preferably, rename MAR_START_PHI to MAR_START_ANGLE, then use the selected rotation axis to decide which header field to update.
The workaround for the moment is to always pretend to be using the "phi" axis.
The text was updated successfully, but these errors were encountered: