Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for neovim / Coc #99

Closed
beyarkay opened this issue Mar 13, 2022 · 18 comments
Closed

No support for neovim / Coc #99

beyarkay opened this issue Mar 13, 2022 · 18 comments
Assignees
Labels
conclusion: duplicate Has already been submitted type: enhancement Proposed improvement

Comments

@beyarkay
Copy link

Bug Report

Current behavior

Currently, there's no way to get language server in neovim via Coc

Expected behavior

It would be amazing to have hints and language support in neovim via Coc

Environment

  • Language Server version (commit hash): None applicable
  • CLI version used (output of arduino-cli version): None applicable
  • OS and platform: MacOS 12
@per1234 per1234 added the type: enhancement Proposed improvement label Mar 13, 2022
@drank40
Copy link

drank40 commented Mar 13, 2022

It used to work flawlessy, this is a regression

@beyarkay
Copy link
Author

@drank40 can you confirm the steps you used to you used to install it as a language server?

@drank40
Copy link

drank40 commented Mar 16, 2022

I followed
https://github.com/neoclide/coc.nvim/wiki/Language-servers#[Arduino](https://github.com/neoclide/coc.nvim/wiki/Language-servers#Arduino)

I just added this lines to my coc-settings.json and it worked, but it appears to be broken now, since the language server closes the connection at every request

@drank40
Copy link

drank40 commented Mar 16, 2022

@steprobe

This comment was marked as spam.

@atrosekta
Copy link

same here too, coc's logs says the server is repeatedly stopping as soon as it start ,same with nvim lsp, tho i can launch the server "by hand" without it stopping

@chmanie
Copy link

chmanie commented Jul 28, 2022

For me, using nvim-lsp, it does run for some time but then crashes intermittently. Are we talking about the same issue or is this different behavior?

@dbmzzo
Copy link

dbmzzo commented Aug 6, 2022

For me, using nvim-lsp, it does run for some time but then crashes intermittently.

This is the behavior I'm seeing as well, using nvim-lspconfig.

@beyarkay
Copy link
Author

beyarkay commented Aug 6, 2022

@per1234 @cmaglie is this issue likely to be fixed in the near future? Or alternatively, is the repository accepting PRs?

@per1234
Copy link
Contributor

per1234 commented Aug 6, 2022

is the repository accepting PRs?

Yes. We have already received some high quality PRs which resulted in valuable contributions to the Arduino Language Server project.

One thing that should be noted is that the primary purpose of this project is to serve as the language server component of Arduino IDE 2.x. The use of the standardized language server protocol makes it a general purpose tool that can be used in other applications and it is very cool that people are already using it in such alternative applications. However, that use case will always be a lower priority for the project relative to the use in the development tools created by Arduino such as Arduino IDE 2.x.

@beyarkay
Copy link
Author

beyarkay commented Aug 6, 2022

So reading between the lines, support for non-arduino editors is not available, but the project is willing to accept (high quality) PRs if they add that support?

(I'll take silence to mean a yes)

@beyarkay
Copy link
Author

beyarkay commented Aug 6, 2022

Sorry I'm realising that comment could come across a little aggressive, which is not my intention at all. Just wanting to get a clear idea of the state of support for non-arduino features before I go and try fix the problem myself.

Thanks for the help!

@adamansky

This comment was marked as off-topic.

@attilastrba

This comment was marked as spam.

@adamansky

This comment was marked as spam.

@attilastrba

This comment was marked as off-topic.

@adamansky

This comment was marked as off-topic.

@arduino arduino locked as off-topic and limited conversation to collaborators Jun 26, 2023
@per1234 per1234 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2023
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Jun 26, 2023
@per1234 per1234 assigned per1234 and unassigned cmaglie Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
conclusion: duplicate Has already been submitted type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

10 participants