Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include UseSerilogRequestLogging #468

Open
fgheysels opened this issue Nov 15, 2021 · 2 comments
Open

Include UseSerilogRequestLogging #468

fgheysels opened this issue Nov 15, 2021 · 2 comments
Assignees
Labels
area:telemetry All issues related to telemetry enhancement New feature or request template-area:web-api All issues related to templates for Web APIs

Comments

@fgheysels
Copy link
Member

Should we include UseSerilogRequetLogging in the web-api template ?

With regular logging, logs are quite stuffed with traces regarding the request and response that is generated by ASP.NET. When including the UseSerilogRequestLogging middleware, those logs are tidied up a little bit.
More background info can be found here: https://andrewlock.net/using-serilog-aspnetcore-in-asp-net-core-3-reducing-log-verbosity/

@stijnmoreels
Copy link
Member

Interesting. But the Arcus request tracking is also there, right? That doesn't fix a little bit the problem?
Otherwise, yeah, definitely a thing to consider.

@stijnmoreels stijnmoreels added area:telemetry All issues related to telemetry enhancement New feature or request template-area:web-api All issues related to templates for Web APIs labels Nov 15, 2021
@stijnmoreels stijnmoreels added this to the v0.8.0 milestone Nov 15, 2021
@stijnmoreels
Copy link
Member

The way the Serilog request middleware component is set up, it seems that they do kind of the same thing as we do with the HTTP request tracking middleware, but since we also make sure that we provide additional options for tracking headers and bodies, the added-value of this middleware component is maybe not much anymore. It could even obscure the logging as we would track the request twice, in that case.

@stijnmoreels stijnmoreels modified the milestones: v0.8.0, v0.9 Jun 2, 2022
@stijnmoreels stijnmoreels modified the milestones: v1.0, v1.1 Nov 9, 2022
@stijnmoreels stijnmoreels removed this from the v1.1 milestone Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:telemetry All issues related to telemetry enhancement New feature or request template-area:web-api All issues related to templates for Web APIs
Projects
None yet
Development

No branches or pull requests

2 participants