Do not use a custom config-key for ApplicationInsights' instrumentation-key

[fgheysels]

When creating a new Web API using the Arcus template, some code is generated to setup Application Insights logging.

The template code expects the instrumentation-key to be in a custom configuration-setting (Telemetry:ApplicationInsights:InstrumentationKey) as you can see here.

However, I think it is better if we use one of the 'default' configuration values. There are 2 settings documented in Microsoft's docs ( ApplicationInsights:InstrumentationKey and APPINSIGHTS_INSTRUMENTATIONKEY.

I've found that, when using APPINSIGHTS_INSTRUMENTATIONKEY, the Azure Portal also recognizes that App Insights logging has been setup. I'd be in favor of using the APPINSIGHTS_INSTRUMENTATIONKEY setting in Arcus templates as wel, instead of that custom setting.

Any thoughts @gverstraete @scleynen ?

[gverstraete]

I can agree with that, but isn't there a connectionstring alternative?

Ref: https://docs.microsoft.com/en-us/azure/azure-monitor/app/sdk-connection-string?tabs=net

[fgheysels]

I have another issue for that , as I think these are 2 separate items.
I think the quick win here , is to change our Arcus templates to use the more 'standard' config-setting.
In the meantime, we should add an additional extension method in Arcus Observability to support AppInsights' connectionstrings

arcus-azure/arcus.observability#354

[scleynen]

Yes indeed, in the projects where I used the Arcus Library I actually added the same key twice. Once with the custom config and once with the microsoft one to make the portal work indeed. So I think it is a good idea to standardize on it

…

On Mon, Mar 21, 2022 at 9:49 AM Frederik Gheysels ***@***.***> wrote: When creating a new Web API using the Arcus template, some code is generated to setup Application Insights logging. The template code expects the instrumentation-key to be in a custom configuration-setting (Telemetry:ApplicationInsights:InstrumentationKey) as you can see here <https://github.com/arcus-azure/arcus.templates/blob/ada3dfe76812107a9a584b18f6569f7eb9dc3054/src/Arcus.Templates.WebApi/Program.cs#L55> . However, I think it is better if we use one of the 'default' configuration values. There are 2 settings documented in Microsoft's docs ( ApplicationInsights:InstrumentationKey and APPINSIGHTS_INSTRUMENTATIONKEY. I've found that, when using APPINSIGHTS_INSTRUMENTATIONKEY, the Azure Portal also recognizes that App Insights logging has been setup. I'd be in favor of using the APPINSIGHTS_INSTRUMENTATIONKEY setting in Arcus templates as wel, instead of that custom setting. Any thoughts @gverstraete <https://github.com/gverstraete> @scleynen <https://github.com/scleynen> ? — Reply to this email directly, view it on GitHub <#536>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVTNJUYT3ZKJDXJGTJGU4DVBAZ2HANCNFSM5RG7S22A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[fgheysels]

I think this issue has already been handled / fixed ?