Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable optimizations in resetSharedRadii #1205

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Disable optimizations in resetSharedRadii #1205

wants to merge 1 commit into from

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Jan 16, 2025

Fix #1186.

@aprokop aprokop added the bug Something isn't working label Jan 16, 2025
@aprokop aprokop marked this pull request as draft January 16, 2025 04:29
aprokop
aprokop commented Jan 16, 2025
View reviewed changes
src/cluster/detail/ArborX_BoruvkaHelpers.hpp
@@ -685,6 +685,10 @@ void resetSharedRadii(ExecutionSpace const &space, BVH const &bvh,
Labels const &labels, Metric const &metric,
Radii const &radii)
{
#if defined(KOKKOS_COMPILER_CLANG) && !defined(__HIP_DEVICE_COMPILE__)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to restrict it to a single platform.

@aprokop
Copy link
Contributor Author

aprokop commented Jan 16, 2025

This only fixed ArborX_Test_DetailsClusteringHelpers.exe. ArborX_Test_Clustering.exe still fails with memory violation. Maybe some other function would need the same treatment. In general, I am baffled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing clustering helpers test
1 participant
@aprokop