From a1580948233f0b179e48bf9b13ed68910635d04a Mon Sep 17 00:00:00 2001 From: Claudia Date: Fri, 8 Nov 2024 16:11:34 +0100 Subject: [PATCH 1/5] feat: update changelog --- packages/contracts/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/contracts/CHANGELOG.md b/packages/contracts/CHANGELOG.md index 20203657..02876369 100644 --- a/packages/contracts/CHANGELOG.md +++ b/packages/contracts/CHANGELOG.md @@ -10,6 +10,8 @@ and this project adheres to the [Aragon OSx Plugin Versioning Convention](https: ### Added - Copied files from [aragon/osx commit 1130df](https://github.com/aragon/osx/commit/1130dfce94fd294c4341e91a8f3faccc54cf43b7) +- `hasSucceeded`, `createProposal`, `customProposalParamsABI`, `canExecute` and `execute` function according to `IProposal` interface. +- `initialize` function also receives `TargetConfig` with the optional target config. ### Changed From 8f003c1b298096e9662685436d12940c01e29079 Mon Sep 17 00:00:00 2001 From: Claudia Date: Fri, 8 Nov 2024 16:11:47 +0100 Subject: [PATCH 2/5] feat: update build metadata --- packages/contracts/src/build-metadata.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/contracts/src/build-metadata.json b/packages/contracts/src/build-metadata.json index 5c53a36b..4e8d35d1 100644 --- a/packages/contracts/src/build-metadata.json +++ b/packages/contracts/src/build-metadata.json @@ -6,29 +6,29 @@ "description": "The information required for the installation.", "inputs": [ { - "internalType": "address", "name": "admin", "type": "address", + "internalType": "address", "description": "The address of the admin account receiving the `EXECUTE_PERMISSION_ID` permission." }, { "components": [ { - "internalType": "address", "name": "target", "type": "address", + "internalType": "address", "description": "The target contract to which actions will be forwarded to for execution." }, { - "internalType": "uint8", "name": "operation", "type": "uint8", + "internalType": "uint8", "description": "The operation type(either `call` or `delegatecall`) that will be used for execution forwarding." } ], - "internalType": "struct TokenVoting.TargetConfig", "name": "TargetConfig", "type": "tuple", + "internalType": "struct TokenVoting.TargetConfig", "description": "The initial target config" } ] From d3db6cddd3618f9d40870070d65db1b57a82b15b Mon Sep 17 00:00:00 2001 From: Claudia Date: Fri, 8 Nov 2024 16:13:12 +0100 Subject: [PATCH 3/5] ci: fix format --- packages/contracts/CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/contracts/CHANGELOG.md b/packages/contracts/CHANGELOG.md index 02876369..3cdeb743 100644 --- a/packages/contracts/CHANGELOG.md +++ b/packages/contracts/CHANGELOG.md @@ -10,8 +10,8 @@ and this project adheres to the [Aragon OSx Plugin Versioning Convention](https: ### Added - Copied files from [aragon/osx commit 1130df](https://github.com/aragon/osx/commit/1130dfce94fd294c4341e91a8f3faccc54cf43b7) -- `hasSucceeded`, `createProposal`, `customProposalParamsABI`, `canExecute` and `execute` function according to `IProposal` interface. -- `initialize` function also receives `TargetConfig` with the optional target config. +- `hasSucceeded`, `createProposal`, `customProposalParamsABI`, `canExecute` and `execute` function according to `IProposal` interface. +- `initialize` function also receives `TargetConfig` with the optional target config. ### Changed From 5d10ed04e3ff6d7a731586dad9109e2b5434f436 Mon Sep 17 00:00:00 2001 From: Claudia Date: Fri, 8 Nov 2024 16:24:18 +0100 Subject: [PATCH 4/5] fix: wording --- packages/contracts/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/contracts/CHANGELOG.md b/packages/contracts/CHANGELOG.md index 3cdeb743..530456bf 100644 --- a/packages/contracts/CHANGELOG.md +++ b/packages/contracts/CHANGELOG.md @@ -10,7 +10,7 @@ and this project adheres to the [Aragon OSx Plugin Versioning Convention](https: ### Added - Copied files from [aragon/osx commit 1130df](https://github.com/aragon/osx/commit/1130dfce94fd294c4341e91a8f3faccc54cf43b7) -- `hasSucceeded`, `createProposal`, `customProposalParamsABI`, `canExecute` and `execute` function according to `IProposal` interface. +- `hasSucceeded`, `createProposal`, `customProposalParamsABI`, `canExecute` and `execute` function implementing to `IProposal` interface. - `initialize` function also receives `TargetConfig` with the optional target config. ### Changed From cf757e1575d63144e86beecfeaf279d8801f1a6a Mon Sep 17 00:00:00 2001 From: Claudia Date: Fri, 8 Nov 2024 16:24:37 +0100 Subject: [PATCH 5/5] typo --- packages/contracts/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/contracts/CHANGELOG.md b/packages/contracts/CHANGELOG.md index 530456bf..0b48317b 100644 --- a/packages/contracts/CHANGELOG.md +++ b/packages/contracts/CHANGELOG.md @@ -10,7 +10,7 @@ and this project adheres to the [Aragon OSx Plugin Versioning Convention](https: ### Added - Copied files from [aragon/osx commit 1130df](https://github.com/aragon/osx/commit/1130dfce94fd294c4341e91a8f3faccc54cf43b7) -- `hasSucceeded`, `createProposal`, `customProposalParamsABI`, `canExecute` and `execute` function implementing to `IProposal` interface. +- `hasSucceeded`, `createProposal`, `customProposalParamsABI`, `canExecute` and `execute` functions implementing to `IProposal` interface. - `initialize` function also receives `TargetConfig` with the optional target config. ### Changed