Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting by CMC just sorts alphabetically #69

Open
mlex121 opened this issue Dec 17, 2019 · 3 comments
Open

Sorting by CMC just sorts alphabetically #69

mlex121 opened this issue Dec 17, 2019 · 3 comments

Comments

@mlex121
Copy link

mlex121 commented Dec 17, 2019

When I put in my Jund Sacrifice decklist and hit sort by CMC I get all of the cards sorted in alphabetical order instead. I've seen this issue before with my Dredge decklist too.

Screenshot included for clarity:
decklist-org-sort-by-cmc-broken

If it helps, this is the maindeck and sideboard I used:

3 Beanstalk Giant
4 Blood Crypt
1 Castle Locthwain
4 Casualties of War
4 Cauldron Familiar
4 Fabled Passage
5 Forest
4 Gilded Goose
3 Korvold, Fae-Cursed King
1 Massacre Girl
4 Mayhem Devil
1 Mountain
3 Murderous Rider
4 Overgrown Tomb
4 Stomping Ground
2 Swamp
1 Thrashing Brontodon
4 Trail of Crumbs
4 Witch's Oven
2 Duress
3 Lovestruck Beast
1 Massacre Girl
4 Noxious Grasp
2 Shifting Ceratops
1 Thrashing Brontodon
2 Wicked Wolf
@mlex121
Copy link
Author

mlex121 commented Dec 17, 2019

Doing a bit of investigating, it looks like in recent iterations of your minified card database the m value (I'm assuming this is mana cost) is 99 for every card. It looks like this changed in the following commit: e8c0353#diff-bdfbee1a8ea3d6e692992108bd5c18b1

@mlex121
Copy link
Author

mlex121 commented Dec 17, 2019

Talking about this file: js/cards/decklist-cards-min.js

@Nightfirecat
Copy link
Contributor

This would be fixed by #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants