Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ci timeout to 50m #1140

Closed
wants to merge 1 commit into from
Closed

Conversation

gunli
Copy link
Contributor

@gunli gunli commented Dec 1, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Currently, the CI timeout is 20m, it fails frequently.

Modifications

go test -race -coverprofile=/tmp/coverage -timeout=50m -v ./...

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Member

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The time for most successful CI jobs is less than 20 minutes. https://github.com/apache/pulsar-client-go/actions/workflows/ci.yml?query=is%3Asuccess

Increasing the timeout may increase CI overhead and block other CI jobs.

@gunli
Copy link
Contributor Author

gunli commented Dec 1, 2023

The time for most successful CI jobs is less than 20 minutes. https://github.com/apache/pulsar-client-go/actions/workflows/ci.yml?query=is%3Asuccess

Increasing the timeout may increase CI overhead and block other CI jobs.

But it fails frequently, even if I run it on my local host.

@RobertIndie
Copy link
Member

But it fails frequently, even if I run it on my local host.

What is the cause of the failure? Do you have any link to your CI failure?

@gunli
Copy link
Contributor Author

gunli commented Dec 7, 2023

But it fails frequently, even if I run it on my local host.

What is the cause of the failure? Do you have any link to your CI failure?

Maybe it is something to do with the data race of #1134 , I will close this PR.

@gunli gunli closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants